| Message ID | 20200831213758.206690-1-mathieu.poirier@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cb2d8d5b196c2e96e29343383c8c8d8db68b934e |
| Headers | show |
| Series | remoteproc: stm32: Fix pointer assignement | expand |
Hi Mathieu, On 8/31/20 11:37 PM, Mathieu Poirier wrote: > Fix the assignment of the @state pointer - it is obviously wrong. > > Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> Thanks, Arnaud > --- > drivers/remoteproc/stm32_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index f4da42fc0eeb..d2414cc1d90d 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -685,7 +685,7 @@ static int stm32_rproc_get_m4_status(struct stm32_rproc *ddata, > * We couldn't get the coprocessor's state, assume > * it is not running. > */ > - state = M4_STATE_OFF; > + *state = M4_STATE_OFF; > return 0; > } > >
Hello: This patch was applied to andersson/remoteproc.git (refs/heads/for-next). On Mon, 31 Aug 2020 15:37:58 -0600 you wrote: > Fix the assignment of the @state pointer - it is obviously wrong. > > Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > --- > drivers/remoteproc/stm32_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is a summary with links: - remoteproc: stm32: Fix pointer assignement https://git.kernel.org/andersson/remoteproc/c/cb2d8d5b196c2e96e29343383c8c8d8db68b934e You are awesome, thank you!
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index f4da42fc0eeb..d2414cc1d90d 100644 --- a/drivers/remoteproc/stm32_rproc.c +++ b/drivers/remoteproc/stm32_rproc.c @@ -685,7 +685,7 @@ static int stm32_rproc_get_m4_status(struct stm32_rproc *ddata, * We couldn't get the coprocessor's state, assume * it is not running. */ - state = M4_STATE_OFF; + *state = M4_STATE_OFF; return 0; }
Fix the assignment of the @state pointer - it is obviously wrong. Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> --- drivers/remoteproc/stm32_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)