| Message ID | 1598948837-740-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fff15f23b8e74c2f969a5d25f29d0565e76e7137 |
| Headers | show |
| Series | [v2] thunderbolt: Use kobj_to_dev() instead of container_of() | expand |
On Tue, Sep 01, 2020 at 04:27:17PM +0800, Tian Tao wrote: > Doesn't really matter for an individual driver, but it may > get coppied to lots more. I consider it's a little tidy up. > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> Applied, thanks!
diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c index bba4cbf..7a192b7 100644 --- a/drivers/thunderbolt/domain.c +++ b/drivers/thunderbolt/domain.c @@ -275,7 +275,7 @@ static struct attribute *domain_attrs[] = { static umode_t domain_attr_is_visible(struct kobject *kobj, struct attribute *attr, int n) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct tb *tb = container_of(dev, struct tb, dev); if (attr == &dev_attr_boot_acl.attr) { diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index a921de9..173ce3b 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -1649,7 +1649,7 @@ static struct attribute *switch_attrs[] = { static umode_t switch_attr_is_visible(struct kobject *kobj, struct attribute *attr, int n) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct tb_switch *sw = tb_to_switch(dev); if (attr == &dev_attr_device.attr) {
Doesn't really matter for an individual driver, but it may get coppied to lots more. I consider it's a little tidy up. Signed-off-by: Tian Tao <tiantao6@hisilicon.com> v2: rewrite the commit message. --- drivers/thunderbolt/domain.c | 2 +- drivers/thunderbolt/switch.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)