| Message ID | 20200902153846.GA10327@embeddedor (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | power: supply: charger-manager: Fix info message in check_charging_duration() | expand |
On 9/2/20 8:38 AM, Gustavo A. R. Silva wrote: > A few months ago, commit e132fc6bb89b ("power: supply: charger-manager: Make decisions focussed on battery status") > changed the expression in the if statement from "duration > desc->discharging_max_duration_ms" > to "duration > desc->charging_max_duration_ms", but the arguments for dev_info() were left unchanged. > Apparently, due to a copy-paste error. > > Fix this by using the proper arguments for dev_info(). > > Addresses-Coverity-ID: 1496803 ("Copy-paste error") > Fixes: e132fc6bb89b ("power: supply: charger-manager: Make decisions focussed on battery status") > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/power/supply/charger-manager.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c > index 07992821e252..6117018e89df 100644 > --- a/drivers/power/supply/charger-manager.c > +++ b/drivers/power/supply/charger-manager.c > @@ -472,8 +472,8 @@ static int check_charging_duration(struct charger_manager *cm) > duration = curr - cm->charging_end_time; > > if (duration > desc->charging_max_duration_ms) { > - dev_info(cm->dev, "Discharging duration exceed %ums\n", > - desc->discharging_max_duration_ms); > + dev_info(cm->dev, "Charging duration exceed %ums\n", preferably exceeds > + desc->charging_max_duration_ms); > ret = true; > } > } > thanks.
diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c index 07992821e252..6117018e89df 100644 --- a/drivers/power/supply/charger-manager.c +++ b/drivers/power/supply/charger-manager.c @@ -472,8 +472,8 @@ static int check_charging_duration(struct charger_manager *cm) duration = curr - cm->charging_end_time; if (duration > desc->charging_max_duration_ms) { - dev_info(cm->dev, "Discharging duration exceed %ums\n", - desc->discharging_max_duration_ms); + dev_info(cm->dev, "Charging duration exceed %ums\n", + desc->charging_max_duration_ms); ret = true; } }
A few months ago, commit e132fc6bb89b ("power: supply: charger-manager: Make decisions focussed on battery status") changed the expression in the if statement from "duration > desc->discharging_max_duration_ms" to "duration > desc->charging_max_duration_ms", but the arguments for dev_info() were left unchanged. Apparently, due to a copy-paste error. Fix this by using the proper arguments for dev_info(). Addresses-Coverity-ID: 1496803 ("Copy-paste error") Fixes: e132fc6bb89b ("power: supply: charger-manager: Make decisions focussed on battery status") Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/power/supply/charger-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)