| Message ID | 20200902204847.2764-3-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] mmc: davinci: Fix -Wpointer-to-int-cast on compile test | expand |
On Wed, 2 Sep 2020 at 22:49, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Since driver data is a pointer, direct casting to integer causes > warning when compile testing for 64-bit architecture: > > drivers/mmc/host/s3cmci.c:1495:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > > The actual driver data can be only 0 or 1, so cast it via long and do > not care about any loss of value. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/s3cmci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c > index 3fb597095079..ac94f926624d 100644 > --- a/drivers/mmc/host/s3cmci.c > +++ b/drivers/mmc/host/s3cmci.c > @@ -1492,7 +1492,7 @@ static int s3cmci_probe_dt(struct s3cmci_host *host) > struct mmc_host *mmc = host->mmc; > int ret; > > - host->is2440 = (int) of_device_get_match_data(&pdev->dev); > + host->is2440 = (long) of_device_get_match_data(&pdev->dev); > > ret = mmc_of_parse(mmc); > if (ret) > -- > 2.17.1 >
diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index 3fb597095079..ac94f926624d 100644 --- a/drivers/mmc/host/s3cmci.c +++ b/drivers/mmc/host/s3cmci.c @@ -1492,7 +1492,7 @@ static int s3cmci_probe_dt(struct s3cmci_host *host) struct mmc_host *mmc = host->mmc; int ret; - host->is2440 = (int) of_device_get_match_data(&pdev->dev); + host->is2440 = (long) of_device_get_match_data(&pdev->dev); ret = mmc_of_parse(mmc); if (ret)
Since driver data is a pointer, direct casting to integer causes warning when compile testing for 64-bit architecture: drivers/mmc/host/s3cmci.c:1495:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] The actual driver data can be only 0 or 1, so cast it via long and do not care about any loss of value. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mmc/host/s3cmci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)