| Message ID | cover.1599144062.git.qemu_oss@crudebyte.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | 9pfs: log warning if msize <= 8192 | expand |
On Thu, 3 Sep 2020 17:19:31 +0200 Greg Kurz <groug@kaod.org> wrote: > On Thu, 3 Sep 2020 16:41:02 +0200 > Christian Schoenebeck <qemu_oss@crudebyte.com> wrote: > > > I have updated the QEMU 9P setup wiki page about this 'msize' issue. For > > some reason the dedicated anchor 'msize' does not work though: > > > > https://wiki.qemu.org/Documentation/9psetup#msize > > > > AFAICT the wiki derives the anchor from the section name, ie. > > https://wiki.qemu.org/Documentation/9psetup#Performance_Considerations > > It's a bit longer than #msize but it works. I don't know if you can > add anchors manually in the wiki. > It seems you could achieve this without the template: == <span id="msize">Performance Considerations</span> == > > Not sure whether that's a wiki installation problem? When I view the wiki > > source, it looks like it is showing some errors there. > > > > v1->v2: > > > > * Updated commit log message to make it more clear why the client cannot > > auto pick a good value for 'msize'. > > > > * Added a web link to the log message, pointing to the appropriate QEMU > > wiki page which explains the 'msize' issue in detail. > > > > Message-ID of previous version (v1): > > E1kDR8W-0001s4-Sr@lizzy.crudebyte.com > > > > Christian Schoenebeck (1): > > 9pfs: log warning if msize <= 8192 > > > > hw/9pfs/9p.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > >
On Donnerstag, 3. September 2020 17:41:23 CEST Greg Kurz wrote: > On Thu, 3 Sep 2020 17:19:31 +0200 > > Greg Kurz <groug@kaod.org> wrote: > > On Thu, 3 Sep 2020 16:41:02 +0200 > > > > Christian Schoenebeck <qemu_oss@crudebyte.com> wrote: > > > I have updated the QEMU 9P setup wiki page about this 'msize' issue. For > > > some reason the dedicated anchor 'msize' does not work though: > > > > > > https://wiki.qemu.org/Documentation/9psetup#msize > > > > AFAICT the wiki derives the anchor from the section name, ie. > > > > https://wiki.qemu.org/Documentation/9psetup#Performance_Considerations > > > > It's a bit longer than #msize but it works. I don't know if you can > > add anchors manually in the wiki. > > It seems you could achieve this without the template: > > == <span id="msize">Performance Considerations</span> == What I tried was this (as wiki source): <!-- NOTE: anchor 'msize' is linked by a QEMU 9pfs log message in 9p.c --> {{anchor|msize}} == Performance Considerations == Which "should" work according to: https://en.wikipedia.org/wiki/Template:Anchor However after I did those changes I saw some template errors as comment in the generated HTML sources, which now are gone at least. I wait a bit to see if it is maybe just a caching problem. If it still doesn't work in a while, I will update it with your solution a bit later. Thanks for the hint! Best regards, Christian Schoenebeck
On Thu, 03 Sep 2020 17:48:33 +0200 Christian Schoenebeck <qemu_oss@crudebyte.com> wrote: > On Donnerstag, 3. September 2020 17:41:23 CEST Greg Kurz wrote: > > On Thu, 3 Sep 2020 17:19:31 +0200 > > > > Greg Kurz <groug@kaod.org> wrote: > > > On Thu, 3 Sep 2020 16:41:02 +0200 > > > > > > Christian Schoenebeck <qemu_oss@crudebyte.com> wrote: > > > > I have updated the QEMU 9P setup wiki page about this 'msize' issue. For > > > > some reason the dedicated anchor 'msize' does not work though: > > > > > > > > https://wiki.qemu.org/Documentation/9psetup#msize > > > > > > AFAICT the wiki derives the anchor from the section name, ie. > > > > > > https://wiki.qemu.org/Documentation/9psetup#Performance_Considerations > > > > > > It's a bit longer than #msize but it works. I don't know if you can > > > add anchors manually in the wiki. > > > > It seems you could achieve this without the template: > > > > == <span id="msize">Performance Considerations</span> == > > What I tried was this (as wiki source): > > <!-- NOTE: anchor 'msize' is linked by a QEMU 9pfs log message in 9p.c --> > {{anchor|msize}} > == Performance Considerations == > > Which "should" work according to: > https://en.wikipedia.org/wiki/Template:Anchor > > However after I did those changes I saw some template errors as comment in the > generated HTML sources, which now are gone at least. > > I wait a bit to see if it is maybe just a caching problem. If it still doesn't > work in a while, I will update it with your solution a bit later. > > Thanks for the hint! > Found here: https://meta.wikimedia.org/wiki/Help:Link#Manual_anchors > Best regards, > Christian Schoenebeck > >
I have updated the QEMU 9P setup wiki page about this 'msize' issue. For some reason the dedicated anchor 'msize' does not work though: https://wiki.qemu.org/Documentation/9psetup#msize Not sure whether that's a wiki installation problem? When I view the wiki source, it looks like it is showing some errors there. v1->v2: * Updated commit log message to make it more clear why the client cannot auto pick a good value for 'msize'. * Added a web link to the log message, pointing to the appropriate QEMU wiki page which explains the 'msize' issue in detail. Message-ID of previous version (v1): E1kDR8W-0001s4-Sr@lizzy.crudebyte.com Christian Schoenebeck (1): 9pfs: log warning if msize <= 8192 hw/9pfs/9p.c | 9 +++++++++ 1 file changed, 9 insertions(+)