Message ID | 20200903160052.8806-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | [4.4.y-cip] of: Add missing exports of node name compare functions | expand |
Hi! > commit 173ee3962959a1985a109f81539a403b5cd07ae7 upstream. > > Commit f42b0e18f2e5 ("of: add node name compare helper functions") > failed to add the module exports to of_node_name_eq() and > of_node_name_prefix(). Add them now. > > Fixes: f42b0e18f2e5 ("of: add node name compare helper functions") > Signed-off-by: Rob Herring <robh@kernel.org> > Signed-off-by: Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > Fixes build failure for multi_v7_defconfig > --- Ok, what is going on here? I don't believe f42b0e18f2e5 causes build failure; it adds functions, but it can't cause build failure without a user. Which commit fails the build? Do we have that in 4.4.y-cip? Can this be placed before the buggy commit so that build is not broken? Best regards, Pavel
Hi Pavel, Thank you for the review. > -----Original Message----- > From: Pavel Machek <pavel@denx.de> > Sent: 03 September 2020 18:32 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Biju Das > <biju.das.jz@bp.renesas.com> > Subject: Re: [PATCH 4.4.y-cip] of: Add missing exports of node name compare functions > > Hi! > > > commit 173ee3962959a1985a109f81539a403b5cd07ae7 upstream. > > > > Commit f42b0e18f2e5 ("of: add node name compare helper functions") > > failed to add the module exports to of_node_name_eq() and > > of_node_name_prefix(). Add them now. > > > > Fixes: f42b0e18f2e5 ("of: add node name compare helper functions") > > Signed-off-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Lad Prabhakar > > <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > Fixes build failure for multi_v7_defconfig > > --- > > Ok, what is going on here? > > I don't believe f42b0e18f2e5 causes build failure; it adds functions, > but it can't cause build failure without a user. > > Which commit fails the build? Do we have that in 4.4.y-cip? Can > this be placed before the buggy commit so that build is not broken? > For multi_v7_defconfig I get this below build error: ERROR: "of_node_name_eq" [drivers/gpu/drm/rcar-du/rcar-du-drm.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1161: recipe for target 'modules' failed make: *** [modules] Error 2 commit eeaa48eee492d ("drm: rcar-du: Support panels connected directly to the DPAD outputs") fails the build which was added in 4.4-cip kernel. Cheers, Prabhakar Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5405): https://lists.cip-project.org/g/cip-dev/message/5405 Mute This Topic: https://lists.cip-project.org/mt/76610346/4520428 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy [patchwork-cip-dev@patchwork.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi! > > > Commit f42b0e18f2e5 ("of: add node name compare helper functions") > > > failed to add the module exports to of_node_name_eq() and > > > of_node_name_prefix(). Add them now. > > > > > > Fixes: f42b0e18f2e5 ("of: add node name compare helper functions") > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > Signed-off-by: Lad Prabhakar > > > <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > --- > > > Fixes build failure for multi_v7_defconfig > > > --- > > > > Ok, what is going on here? > > > > I don't believe f42b0e18f2e5 causes build failure; it adds functions, > > but it can't cause build failure without a user. > > > > Which commit fails the build? Do we have that in 4.4.y-cip? Can > > this be placed before the buggy commit so that build is not broken? > > > For multi_v7_defconfig I get this below build error: > > ERROR: "of_node_name_eq" [drivers/gpu/drm/rcar-du/rcar-du-drm.ko] undefined! > scripts/Makefile.modpost:91: recipe for target '__modpost' failed > make[1]: *** [__modpost] Error 1 > Makefile:1161: recipe for target 'modules' failed > make: *** [modules] Error 2 > > commit eeaa48eee492d ("drm: rcar-du: Support panels connected directly to the DPAD outputs") fails the build which was added in 4.4-cip kernel. > Aha, so I'd expect Fixes: eeaa48eee492d ("drm: rcar-du: Support panels connected directly to the DPAD outputs") in this patch. And yes, this means that failure is real and this patch should go in. ACK. Best regards, Pavel
diff --git a/drivers/of/base.c b/drivers/of/base.c index b02f4b272e5b..4e6af7c6c792 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -67,6 +67,7 @@ bool of_node_name_eq(const struct device_node *np, const char *name) return (strlen(name) == len) && (strncmp(node_name, name, len) == 0); } +EXPORT_SYMBOL(of_node_name_eq); bool of_node_name_prefix(const struct device_node *np, const char *prefix) { @@ -75,6 +76,7 @@ bool of_node_name_prefix(const struct device_node *np, const char *prefix) return strncmp(kbasename(np->full_name), prefix, strlen(prefix)) == 0; } +EXPORT_SYMBOL(of_node_name_prefix); int of_n_addr_cells(struct device_node *np) {