| Message ID | 20200819104655.436656-9-christian.brauner@ubuntu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 25239fd338aa2995f04ce3dc3ef3c01488bd05b3 |
| Headers | show |
| Series | Introduce kernel_clone(), kill _do_fork() | expand |
Hi, On Wed, 19 Aug 2020 12:46:52 +0200 Christian Brauner <christian.brauner@ubuntu.com> wrote: > The old _do_fork() helper is removed in favor of the new kernel_clone() helper. > The latter adheres to naming conventions for kernel internal syscall helpers. This looks good to me. Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Thank you! > > Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > Cc: Alexandre Chartre <alexandre.chartre@oracle.com> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Masami Hiramatsu <mhiramat@kernel.org> > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> > --- > /* v2 */ > unchanged > --- > samples/kprobes/kprobe_example.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c > index 240f2435ce6f..a02f53836ee1 100644 > --- a/samples/kprobes/kprobe_example.c > +++ b/samples/kprobes/kprobe_example.c > @@ -2,13 +2,13 @@ > /* > * NOTE: This example is works on x86 and powerpc. > * Here's a sample kernel module showing the use of kprobes to dump a > - * stack trace and selected registers when _do_fork() is called. > + * stack trace and selected registers when kernel_clone() is called. > * > * For more information on theory of operation of kprobes, see > * Documentation/staging/kprobes.rst > * > * You will see the trace data in /var/log/messages and on the console > - * whenever _do_fork() is invoked to create a new process. > + * whenever kernel_clone() is invoked to create a new process. > */ > > #include <linux/kernel.h> > @@ -16,7 +16,7 @@ > #include <linux/kprobes.h> > > #define MAX_SYMBOL_LEN 64 > -static char symbol[MAX_SYMBOL_LEN] = "_do_fork"; > +static char symbol[MAX_SYMBOL_LEN] = "kernel_clone"; > module_param_string(symbol, symbol, sizeof(symbol), 0644); > > /* For each probe you need to allocate a kprobe structure */ > -- > 2.28.0 >
diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c index 240f2435ce6f..a02f53836ee1 100644 --- a/samples/kprobes/kprobe_example.c +++ b/samples/kprobes/kprobe_example.c @@ -2,13 +2,13 @@ /* * NOTE: This example is works on x86 and powerpc. * Here's a sample kernel module showing the use of kprobes to dump a - * stack trace and selected registers when _do_fork() is called. + * stack trace and selected registers when kernel_clone() is called. * * For more information on theory of operation of kprobes, see * Documentation/staging/kprobes.rst * * You will see the trace data in /var/log/messages and on the console - * whenever _do_fork() is invoked to create a new process. + * whenever kernel_clone() is invoked to create a new process. */ #include <linux/kernel.h> @@ -16,7 +16,7 @@ #include <linux/kprobes.h> #define MAX_SYMBOL_LEN 64 -static char symbol[MAX_SYMBOL_LEN] = "_do_fork"; +static char symbol[MAX_SYMBOL_LEN] = "kernel_clone"; module_param_string(symbol, symbol, sizeof(symbol), 0644); /* For each probe you need to allocate a kprobe structure */
The old _do_fork() helper is removed in favor of the new kernel_clone() helper. The latter adheres to naming conventions for kernel internal syscall helpers. Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Cc: Alexandre Chartre <alexandre.chartre@oracle.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: Masami Hiramatsu <mhiramat@kernel.org> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> --- /* v2 */ unchanged --- samples/kprobes/kprobe_example.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)