diff mbox series

tests: fixes test-vmstate.c compile error on msys2

Message ID 20200905063813.1875-1-luoyonggang@gmail.com (mailing list archive)
State New, archived
Headers show
Series tests: fixes test-vmstate.c compile error on msys2 | expand

Commit Message

Yonggang Luo Sept. 5, 2020, 6:38 a.m. UTC
../tests/test-vmstate.c: In function 'int_cmp':
../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
  884 |     uint ua = GPOINTER_TO_UINT(a);
      |     ^~~~
      |     uInt
../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
  885 |     uint ub = GPOINTER_TO_UINT(b);
      |     ^~~~
      |     uInt
make: *** [Makefile.ninja:5461:tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
 tests/test-vmstate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Huth Sept. 5, 2020, 8:48 a.m. UTC | #1
On 05/09/2020 08.38, Yonggang Luo wrote:
> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   884 |     uint ua = GPOINTER_TO_UINT(a);
>       |     ^~~~
>       |     uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   885 |     uint ub = GPOINTER_TO_UINT(b);
>       |     ^~~~
>       |     uInt
> make: *** [Makefile.ninja:5461:tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
> 
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>  tests/test-vmstate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  /* ID comparison function */
>  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  {
> -    uint ua = GPOINTER_TO_UINT(a);
> -    uint ub = GPOINTER_TO_UINT(b);
> +    guint ua = GPOINTER_TO_UINT(a);
> +    guint ub = GPOINTER_TO_UINT(b);
>      return (ua > ub) - (ua < ub);
>  }

Reviewed-by: Thomas Huth <thuth@redhat.com>
Yonggang Luo Sept. 5, 2020, 4:16 p.m. UTC | #2
On Sat, Sep 5, 2020 at 4:48 PM Thomas Huth <thuth@redhat.com> wrote:

> On 05/09/2020 08.38, Yonggang Luo wrote:
> > ../tests/test-vmstate.c: In function 'int_cmp':
> > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> >   884 |     uint ua = GPOINTER_TO_UINT(a);
> >       |     ^~~~
> >       |     uInt
> > ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> >   885 |     uint ub = GPOINTER_TO_UINT(b);
> >       |     ^~~~
> >       |     uInt
> > make: ***
> [Makefile.ninja:5461:tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
> >
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> > ---
> >  tests/test-vmstate.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> > index f7b3868881..f8de709a0b 100644
> > --- a/tests/test-vmstate.c
> > +++ b/tests/test-vmstate.c
> > @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
> gconstpointer b, gpointer user_data)
> >  /* ID comparison function */
> >  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer
> user_data)
> >  {
> > -    uint ua = GPOINTER_TO_UINT(a);
> > -    uint ub = GPOINTER_TO_UINT(b);
> > +    guint ua = GPOINTER_TO_UINT(a);
> > +    guint ub = GPOINTER_TO_UINT(b);
> >      return (ua > ub) - (ua < ub);
> >  }
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> Does this means quened or to be queued, if that's true, will skip this
next revision
Thomas Huth Sept. 5, 2020, 4:32 p.m. UTC | #3
On 05/09/2020 18.16, 罗勇刚(Yonggang Luo) wrote:
> 
> 
> On Sat, Sep 5, 2020 at 4:48 PM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> wrote:
> 
>     On 05/09/2020 08.38, Yonggang Luo wrote:
>     > ../tests/test-vmstate.c: In function 'int_cmp':
>     > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint';
>     did you mean 'uInt'?
>     >   884 |     uint ua = GPOINTER_TO_UINT(a);
>     >       |     ^~~~
>     >       |     uInt
>     > ../tests/test-vmstate.c:885:5: error: unknown type name 'uint';
>     did you mean 'uInt'?
>     >   885 |     uint ub = GPOINTER_TO_UINT(b);
>     >       |     ^~~~
>     >       |     uInt
>     > make: *** [Makefile.ninja:5461:tests/test-vmstate.exe.p/test-
>     vmstate.c.obj] 错误 1
>     >
>     > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com
>     <mailto:luoyonggang@gmail.com>>
>     > ---
>     >  tests/test-vmstate.c | 4 ++--
>     >  1 file changed, 2 insertions(+), 2 deletions(-)
>     >
>     > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
>     > index f7b3868881..f8de709a0b 100644
>     > --- a/tests/test-vmstate.c
>     > +++ b/tests/test-vmstate.c
>     > @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
>     gconstpointer b, gpointer user_data)
>     >  /* ID comparison function */
>     >  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer
>     user_data)
>     >  {
>     > -    uint ua = GPOINTER_TO_UINT(a);
>     > -    uint ub = GPOINTER_TO_UINT(b);
>     > +    guint ua = GPOINTER_TO_UINT(a);
>     > +    guint ub = GPOINTER_TO_UINT(b);
>     >      return (ua > ub) - (ua < ub);
>     >  }
> 
>     Reviewed-by: Thomas Huth <thuth@redhat.com <mailto:thuth@redhat.com>>
> 
> Does this means quened or to be queued, if that's true, will skip this
> next revision 

No, "Reviewed-by" just means that somebody looked at the patch and
thinks it is right. It does not mean that it is queued yet, but it
certainly helps that the patch gets accepted.
But I've also put the qemu-trivial mailing list on CC: - trivial paches
like this can often get picked up more easily via the trivial queue.
Otherwise this should maybe get merged via the migration tree, or Alex'
or my testing tree.

 Thomas
Philippe Mathieu-Daudé Sept. 5, 2020, 9:33 p.m. UTC | #4
On 9/5/20 8:38 AM, Yonggang Luo wrote:
> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   884 |     uint ua = GPOINTER_TO_UINT(a);
>       |     ^~~~
>       |     uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   885 |     uint ub = GPOINTER_TO_UINT(b);
>       |     ^~~~
>       |     uInt
> make: *** [Makefile.ninja:5461:tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
> 
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  tests/test-vmstate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  /* ID comparison function */
>  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  {
> -    uint ua = GPOINTER_TO_UINT(a);
> -    uint ub = GPOINTER_TO_UINT(b);
> +    guint ua = GPOINTER_TO_UINT(a);
> +    guint ub = GPOINTER_TO_UINT(b);
>      return (ua > ub) - (ua < ub);
>  }
>  
>
Yonggang Luo Sept. 7, 2020, 2:57 a.m. UTC | #5
Bonzini, you need have a look at this

On Sat, Sep 5, 2020 at 2:38 PM Yonggang Luo <luoyonggang@gmail.com> wrote:

> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
>   884 |     uint ua = GPOINTER_TO_UINT(a);
>       |     ^~~~
>       |     uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
>   885 |     uint ub = GPOINTER_TO_UINT(b);
>       |     ^~~~
>       |     uInt
> make: ***
> [Makefile.ninja:5461:tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>  tests/test-vmstate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
> gconstpointer b, gpointer user_data)
>  /* ID comparison function */
>  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  {
> -    uint ua = GPOINTER_TO_UINT(a);
> -    uint ub = GPOINTER_TO_UINT(b);
> +    guint ua = GPOINTER_TO_UINT(a);
> +    guint ub = GPOINTER_TO_UINT(b);
>      return (ua > ub) - (ua < ub);
>  }
>
> --
> 2.28.0.windows.1
>
>
diff mbox series

Patch

diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index f7b3868881..f8de709a0b 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -881,8 +881,8 @@  static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
 /* ID comparison function */
 static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
 {
-    uint ua = GPOINTER_TO_UINT(a);
-    uint ub = GPOINTER_TO_UINT(b);
+    guint ua = GPOINTER_TO_UINT(a);
+    guint ub = GPOINTER_TO_UINT(b);
     return (ua > ub) - (ua < ub);
 }