| Message ID | 20200901111612.10552-4-dafna.hirschfeld@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: staging: rkisp1: add support to V4L2_CAP_IO_MC | expand |
Hi Dafna, On 9/1/20 8:16 AM, Dafna Hirschfeld wrote: > It is not clear if the device is able to support format > V4L2_PIX_FMT_YUV444M so remove it. > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > --- > see the cover letter for details This commit message could have a bit more details, since it will remain in the git history. At least mentioning that it was tested in several configurations and you weren't able to get good frames. In any case: Acked-by: Helen Koike <helen.koike@collabora.com> Thanks Helen > > drivers/staging/media/rkisp1/rkisp1-capture.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c > index 79195e74d995..022b8eeed426 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-capture.c > +++ b/drivers/staging/media/rkisp1/rkisp1-capture.c > @@ -131,12 +131,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_mp_fmts[] = { > .uv_swap = 1, > .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, > }, > - /* yuv444 */ > - { > - .fourcc = V4L2_PIX_FMT_YUV444M, > - .uv_swap = 0, > - .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, > - }, > /* yuv400 */ > { > .fourcc = V4L2_PIX_FMT_GREY, > @@ -243,13 +237,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = { > .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, > .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV420, > }, > - /* yuv444 */ > - { > - .fourcc = V4L2_PIX_FMT_YUV444M, > - .uv_swap = 0, > - .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, > - .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV444, > - }, > /* yuv400 */ > { > .fourcc = V4L2_PIX_FMT_GREY, >
diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c index 79195e74d995..022b8eeed426 100644 --- a/drivers/staging/media/rkisp1/rkisp1-capture.c +++ b/drivers/staging/media/rkisp1/rkisp1-capture.c @@ -131,12 +131,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_mp_fmts[] = { .uv_swap = 1, .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, }, - /* yuv444 */ - { - .fourcc = V4L2_PIX_FMT_YUV444M, - .uv_swap = 0, - .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, - }, /* yuv400 */ { .fourcc = V4L2_PIX_FMT_GREY, @@ -243,13 +237,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = { .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV420, }, - /* yuv444 */ - { - .fourcc = V4L2_PIX_FMT_YUV444M, - .uv_swap = 0, - .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, - .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV444, - }, /* yuv400 */ { .fourcc = V4L2_PIX_FMT_GREY,
It is not clear if the device is able to support format V4L2_PIX_FMT_YUV444M so remove it. Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> --- see the cover letter for details drivers/staging/media/rkisp1/rkisp1-capture.c | 13 ------------- 1 file changed, 13 deletions(-)