| Message ID | 20200907024149.20001-3-chris.packham@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | 98dx3236 i2c related fixes | expand |
On Mon, Sep 07, 2020 at 02:41:48PM +1200, Chris Packham wrote: > The switches with integrated CPUs have only got a single i2c controller. > The incorrectly gained one when they were split from the Armada-XP. > > Fixes: 43e28ba87708 ("ARM: dts: Use armada-370-xp as a base for armada-xp-98dx3236") > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 8/09/20 3:45 am, Andrew Lunn wrote: > On Mon, Sep 07, 2020 at 02:41:48PM +1200, Chris Packham wrote: >> The switches with integrated CPUs have only got a single i2c controller. >> The incorrectly gained one when they were split from the Armada-XP. Someone pointed out a small grammo instead of "The incorrectly" it should be "They incorrectly". Is it worth me sending a v2 just to fix that? >> >> Fixes: 43e28ba87708 ("ARM: dts: Use armada-370-xp as a base for armada-xp-98dx3236") >> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Andrew
On Mon, Sep 07, 2020 at 09:04:48PM +0000, Chris Packham wrote: > > On 8/09/20 3:45 am, Andrew Lunn wrote: > > On Mon, Sep 07, 2020 at 02:41:48PM +1200, Chris Packham wrote: > >> The switches with integrated CPUs have only got a single i2c controller. > >> The incorrectly gained one when they were split from the Armada-XP. > Someone pointed out a small grammo instead of "The incorrectly" it > should be "They incorrectly". Is it worth me sending a v2 just to fix that? You are asking somebody who is dyslexic, and often fails to notice things like this, particularly when written by me :-) Up to you. Andrew
On 8/09/20 9:07 am, Andrew Lunn wrote: > On Mon, Sep 07, 2020 at 09:04:48PM +0000, Chris Packham wrote: >> On 8/09/20 3:45 am, Andrew Lunn wrote: >>> On Mon, Sep 07, 2020 at 02:41:48PM +1200, Chris Packham wrote: >>>> The switches with integrated CPUs have only got a single i2c controller. >>>> The incorrectly gained one when they were split from the Armada-XP. >> Someone pointed out a small grammo instead of "The incorrectly" it >> should be "They incorrectly". Is it worth me sending a v2 just to fix that? > You are asking somebody who is dyslexic, and often fails to notice > things like this, particularly when written by me :-) > > Up to you. I'll send a v2 fixing the grammo and including your r-by. If the series has already been picked up then no great loss.
diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi index 654648b05c7c..aeccedd12574 100644 --- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi +++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi @@ -266,11 +266,6 @@ &i2c0 { reg = <0x11000 0x100>; }; -&i2c1 { - compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c"; - reg = <0x11100 0x100>; -}; - &mpic { reg = <0x20a00 0x2d0>, <0x21070 0x58>; };
The switches with integrated CPUs have only got a single i2c controller. The incorrectly gained one when they were split from the Armada-XP. Fixes: 43e28ba87708 ("ARM: dts: Use armada-370-xp as a base for armada-xp-98dx3236") Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 5 ----- 1 file changed, 5 deletions(-)