| Message ID | 1599468981-17301-6-git-send-email-guohanjun@huawei.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Cleanups for ACPI APD driver | expand |
Hi Hanjun,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pm/linux-next]
[also build test WARNING on v5.9-rc4 next-20200903]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hanjun-Guo/Cleanups-for-ACPI-APD-driver/20200907-170548
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-s022-20200907 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-191-g10164920-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/acpi/acpi_apd.c:250:13: warning: no previous prototype for 'acpi_apd_init' [-Wmissing-prototypes]
250 | void __init acpi_apd_init(void)
| ^~~~~~~~~~~~~
# https://github.com/0day-ci/linux/commit/a8b5a7197395679505a8a3126b829495abe2ae13
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hanjun-Guo/Cleanups-for-ACPI-APD-driver/20200907-170548
git checkout a8b5a7197395679505a8a3126b829495abe2ae13
vim +/acpi_apd_init +250 drivers/acpi/acpi_apd.c
92082a8886f30a Ken Xue 2015-02-06 249
92082a8886f30a Ken Xue 2015-02-06 @250 void __init acpi_apd_init(void)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
On 2020/9/7 19:19, kernel test robot wrote: > Hi Hanjun, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on pm/linux-next] > [also build test WARNING on v5.9-rc4 next-20200903] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Hanjun-Guo/Cleanups-for-ACPI-APD-driver/20200907-170548 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next > config: x86_64-randconfig-s022-20200907 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.2-191-g10164920-dirty > # save the attached .config to linux build tree > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > >>> drivers/acpi/acpi_apd.c:250:13: warning: no previous prototype for 'acpi_apd_init' [-Wmissing-prototypes] > 250 | void __init acpi_apd_init(void) > | ^~~~~~~~~~~~~ Hmm, I didn't get this locally, I think it's because acpi_apd_init() is added in the head file internal.h, but I removed the internal.h inclusion for head file, I will add it back. Thanks Hanjun
Hi Hanjun,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pm/linux-next]
[also build test WARNING on v5.9-rc4 next-20200903]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hanjun-Guo/Cleanups-for-ACPI-APD-driver/20200907-170548
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-r021-20200907 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ab68517e6b7e51b84c4b0e813a30258ec1ce5da5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/acpi/acpi_apd.c:250:13: warning: no previous prototype for function 'acpi_apd_init' [-Wmissing-prototypes]
void __init acpi_apd_init(void)
^
drivers/acpi/acpi_apd.c:250:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void __init acpi_apd_init(void)
^
static
1 warning generated.
# https://github.com/0day-ci/linux/commit/a8b5a7197395679505a8a3126b829495abe2ae13
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hanjun-Guo/Cleanups-for-ACPI-APD-driver/20200907-170548
git checkout a8b5a7197395679505a8a3126b829495abe2ae13
vim +/acpi_apd_init +250 drivers/acpi/acpi_apd.c
92082a8886f30a Ken Xue 2015-02-06 249
92082a8886f30a Ken Xue 2015-02-06 @250 void __init acpi_apd_init(void)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
On 2020/9/7 21:07, kernel test robot wrote: > Hi Hanjun, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on pm/linux-next] > [also build test WARNING on v5.9-rc4 next-20200903] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Hanjun-Guo/Cleanups-for-ACPI-APD-driver/20200907-170548 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next > config: x86_64-randconfig-r021-20200907 (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ab68517e6b7e51b84c4b0e813a30258ec1ce5da5) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > >>> drivers/acpi/acpi_apd.c:250:13: warning: no previous prototype for function 'acpi_apd_init' [-Wmissing-prototypes] > void __init acpi_apd_init(void) > ^ > drivers/acpi/acpi_apd.c:250:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > void __init acpi_apd_init(void) > ^ > static > 1 warning generated. I think this was fixed in v2. Thanks for the report! Hanjun
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 561d9ba..5d50ca7 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -7,17 +7,13 @@ * Wu, Jeff <Jeff.Wu@amd.com> */ -#include <linux/clk-provider.h> -#include <linux/platform_data/clk-fch.h> -#include <linux/platform_device.h> -#include <linux/pm_domain.h> -#include <linux/clkdev.h> #include <linux/acpi.h> +#include <linux/clkdev.h> +#include <linux/clk-provider.h> #include <linux/err.h> #include <linux/io.h> -#include <linux/pm.h> - -#include "internal.h" +#include <linux/platform_data/clk-fch.h> +#include <linux/platform_device.h> struct apd_private_data;
Make the including head files to be alphabetical order, and remove the not needed head file inclusion. Signed-off-by: Hanjun Guo <guohanjun@huawei.com> --- drivers/acpi/acpi_apd.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)