| Message ID | alpine.DEB.2.22.394.2008262252270.2522@hadrien (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | coccinelle: api: fix kobj_to_dev.cocci warnings | expand |
On 8/26/20 10:54 PM, Julia Lawall wrote: > From: kernel test robot <lkp@intel.com> > > Use kobj_to_dev() instead of container_of() > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") > CC: Denis Efremov <efremov@linux.com> > Signed-off-by: kernel test robot <lkp@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr> Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10 > head: a2fc3718bc22e85378085568ecc5765fb28cabce > commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/3] coccinelle: api: add kobj_to_dev.cocci script > :::::: branch date: 5 days ago > :::::: commit date: 5 days ago > > udlfb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/video/fbdev/udlfb.c > +++ b/drivers/video/fbdev/udlfb.c > @@ -1457,7 +1457,7 @@ static ssize_t edid_show( > struct file *filp, > struct kobject *kobj, struct bin_attribute *a, > char *buf, loff_t off, size_t count) { > - struct device *fbdev = container_of(kobj, struct device, kobj); > + struct device *fbdev = kobj_to_dev(kobj); > struct fb_info *fb_info = dev_get_drvdata(fbdev); > struct dlfb_data *dlfb = fb_info->par; > > @@ -1479,7 +1479,7 @@ static ssize_t edid_store( > struct file *filp, > struct kobject *kobj, struct bin_attribute *a, > char *src, loff_t src_off, size_t src_size) { > - struct device *fbdev = container_of(kobj, struct device, kobj); > + struct device *fbdev = kobj_to_dev(kobj); > struct fb_info *fb_info = dev_get_drvdata(fbdev); > struct dlfb_data *dlfb = fb_info->par; > int ret; >
--- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -1457,7 +1457,7 @@ static ssize_t edid_show( struct file *filp, struct kobject *kobj, struct bin_attribute *a, char *buf, loff_t off, size_t count) { - struct device *fbdev = container_of(kobj, struct device, kobj); + struct device *fbdev = kobj_to_dev(kobj); struct fb_info *fb_info = dev_get_drvdata(fbdev); struct dlfb_data *dlfb = fb_info->par; @@ -1479,7 +1479,7 @@ static ssize_t edid_store( struct file *filp, struct kobject *kobj, struct bin_attribute *a, char *src, loff_t src_off, size_t src_size) { - struct device *fbdev = container_of(kobj, struct device, kobj); + struct device *fbdev = kobj_to_dev(kobj); struct fb_info *fb_info = dev_get_drvdata(fbdev); struct dlfb_data *dlfb = fb_info->par; int ret;