Message ID | 20200908195539.25896-2-willy@infradead.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Remove assumptions of THP size | expand |
On Tue, Sep 08, 2020 at 08:55:28PM +0100, Matthew Wilcox (Oracle) wrote: > page_cache_free_page() assumes THPs are PMD_SIZE; fix that assumption. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
On Tue, 8 Sep 2020 20:55:28 +0100 "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote: > page_cache_free_page() assumes THPs are PMD_SIZE; fix that assumption. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Reviewed-by: SeongJae Park <sjpark@amazon.de> Thanks, SeongJae Park
diff --git a/mm/filemap.c b/mm/filemap.c index 1aaea26556cc..c60b94fd74ec 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -249,7 +249,7 @@ static void page_cache_free_page(struct address_space *mapping, freepage(page); if (PageTransHuge(page) && !PageHuge(page)) { - page_ref_sub(page, HPAGE_PMD_NR); + page_ref_sub(page, thp_nr_pages(page)); VM_BUG_ON_PAGE(page_count(page) <= 0, page); } else { put_page(page);
page_cache_free_page() assumes THPs are PMD_SIZE; fix that assumption. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- mm/filemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)