| Message ID | 20200909161514.622998-2-edgar.iglesias@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/arm: versal-virt: Correct the tx/rx GEM clocks | expand |
On 9/9/20 6:15 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Correct the GEMs tx/rx clocks to use the 125Mhz fixed-clock. > This matches the setup with the fixed-link 100Mbit PHY. > I also avoids the following warnings from the Linux kernel > driver: > > eth0: unable to generate target frequency: 125000000 Hz > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/arm/xlnx-versal-virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c > index 4b3152ee77..43d74b850f 100644 > --- a/hw/arm/xlnx-versal-virt.c > +++ b/hw/arm/xlnx-versal-virt.c > @@ -212,7 +212,7 @@ static void fdt_add_gem_nodes(VersalVirt *s) > s->phandle.ethernet_phy[i]); > qemu_fdt_setprop_cells(s->fdt, name, "clocks", > s->phandle.clk_25Mhz, s->phandle.clk_25Mhz, > - s->phandle.clk_25Mhz, s->phandle.clk_25Mhz); > + s->phandle.clk_125Mhz, s->phandle.clk_125Mhz); > qemu_fdt_setprop(s->fdt, name, "clock-names", > clocknames, sizeof(clocknames)); > qemu_fdt_setprop_cells(s->fdt, name, "interrupts", >
On 9/9/20 6:15 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Correct the GEMs tx/rx clocks to use the 125Mhz fixed-clock. > This matches the setup with the fixed-link 100Mbit PHY. > I also avoids the following warnings from the Linux kernel > driver: > > eth0: unable to generate target frequency: 125000000 Hz > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Reviewed-by: Luc Michel <luc.michel@greensocs.com> > --- > hw/arm/xlnx-versal-virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c > index 4b3152ee77..43d74b850f 100644 > --- a/hw/arm/xlnx-versal-virt.c > +++ b/hw/arm/xlnx-versal-virt.c > @@ -212,7 +212,7 @@ static void fdt_add_gem_nodes(VersalVirt *s) > s->phandle.ethernet_phy[i]); > qemu_fdt_setprop_cells(s->fdt, name, "clocks", > s->phandle.clk_25Mhz, s->phandle.clk_25Mhz, > - s->phandle.clk_25Mhz, s->phandle.clk_25Mhz); > + s->phandle.clk_125Mhz, s->phandle.clk_125Mhz); > qemu_fdt_setprop(s->fdt, name, "clock-names", > clocknames, sizeof(clocknames)); > qemu_fdt_setprop_cells(s->fdt, name, "interrupts", >
On Wed, Sep 09, 2020 at 06:15:14PM +0200, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Correct the GEMs tx/rx clocks to use the 125Mhz fixed-clock. > This matches the setup with the fixed-link 100Mbit PHY. > I also avoids the following warnings from the Linux kernel ^^^ Argh, this should say It, not I. I'll send a v2 keeping the RB tags. Cheers, Edgar
diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c index 4b3152ee77..43d74b850f 100644 --- a/hw/arm/xlnx-versal-virt.c +++ b/hw/arm/xlnx-versal-virt.c @@ -212,7 +212,7 @@ static void fdt_add_gem_nodes(VersalVirt *s) s->phandle.ethernet_phy[i]); qemu_fdt_setprop_cells(s->fdt, name, "clocks", s->phandle.clk_25Mhz, s->phandle.clk_25Mhz, - s->phandle.clk_25Mhz, s->phandle.clk_25Mhz); + s->phandle.clk_125Mhz, s->phandle.clk_125Mhz); qemu_fdt_setprop(s->fdt, name, "clock-names", clocknames, sizeof(clocknames)); qemu_fdt_setprop_cells(s->fdt, name, "interrupts",