mbox series

[0/3] Improve error handling

Message ID 20200910073952.212130-1-damien.lemoal@wdc.com (mailing list archive)
Headers show
Series Improve error handling | expand

Message

Damien Le Moal Sept. 10, 2020, 7:39 a.m. UTC 
A small series to improve command error hadling.

The first patch is a simple code cleanup. The second patch updates
asc/ascq sense codes list. Finally, the third patch adds zone resource
errors handling for zoned block deives to return BLK_STS_DEV_RESOURCE,
similarly to what the NVMe driver does for ZNS devices.

Damien Le Moal (3):
  scsi: Cleanup scsi_noretry_cmd()
  scsi: update additional sense codes list
  scsi: handle zone resources errors

 drivers/scsi/scsi_error.c  |  4 +--
 drivers/scsi/scsi_lib.c    | 12 +++++++++
 drivers/scsi/sense_codes.h | 54 +++++++++++++++++++++++++++++++++++++-
 3 files changed, 67 insertions(+), 3 deletions(-)

Comments

Himanshu Madhani Sept. 10, 2020, 2:11 p.m. UTC | #1 
> On Sep 10, 2020, at 2:39 AM, Damien Le Moal <Damien.LeMoal@wdc.com> wrote:
> 
> A small series to improve command error hadling.
> 
> The first patch is a simple code cleanup. The second patch updates
> asc/ascq sense codes list. Finally, the third patch adds zone resource
> errors handling for zoned block deives to return BLK_STS_DEV_RESOURCE,
> similarly to what the NVMe driver does for ZNS devices.
> 
> Damien Le Moal (3):
>  scsi: Cleanup scsi_noretry_cmd()
>  scsi: update additional sense codes list
>  scsi: handle zone resources errors
> 
> drivers/scsi/scsi_error.c  |  4 +--
> drivers/scsi/scsi_lib.c    | 12 +++++++++
> drivers/scsi/sense_codes.h | 54 +++++++++++++++++++++++++++++++++++++-
> 3 files changed, 67 insertions(+), 3 deletions(-)
> 
> -- 
> 2.26.2
> 

For the Series with updated Patch 3. 

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering