| Message ID | 20200907085740.1083-1-t-kristo@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | clk: keystone: some minor fixes | expand |
On 9/7/20 1:57 AM, Tero Kristo wrote: > Hi Santosh, > > This series contains a few fixes for the TI SCI clock driver. > - Patch #1 is a clear bug fix, where we missed to parse assigned-clock > data properly to detect which clocks are in use on the SoC. > - Patch #2 is a performance improvement patch which avoids some > unnecessary round trips to firmware side while setting clock > frequency. > - Patch #3 fixes some issues with set_rate passed to firmware, where the > parameters are too strict; namely, firmware fails to handle some cases > properly if min,tgt,max values for a clock rate are exactly the same > value. Yeah, the firmware is quite weird here but nothing much else we > can do from kernel side other than this.... > Looks fine to me Tero. Acked-by: Santosh Shilimkar <ssantosh@kernel.org> Hi Stephen, Mike, Can you please pick these fixes via clk tree ?
Quoting santosh.shilimkar@oracle.com (2020-09-08 10:19:32) > > > On 9/7/20 1:57 AM, Tero Kristo wrote: > > Hi Santosh, > > > > This series contains a few fixes for the TI SCI clock driver. > > - Patch #1 is a clear bug fix, where we missed to parse assigned-clock > > data properly to detect which clocks are in use on the SoC. > > - Patch #2 is a performance improvement patch which avoids some > > unnecessary round trips to firmware side while setting clock > > frequency. > > - Patch #3 fixes some issues with set_rate passed to firmware, where the > > parameters are too strict; namely, firmware fails to handle some cases > > properly if min,tgt,max values for a clock rate are exactly the same > > value. Yeah, the firmware is quite weird here but nothing much else we > > can do from kernel side other than this.... > > > Looks fine to me Tero. > > Acked-by: Santosh Shilimkar <ssantosh@kernel.org> > > > Hi Stephen, Mike, > Can you please pick these fixes via clk tree ? Sure. I assume this is -next material and not critical fixes.
On 9/10/20 2:29 PM, Stephen Boyd wrote: > Quoting santosh.shilimkar@oracle.com (2020-09-08 10:19:32) >> >> >> On 9/7/20 1:57 AM, Tero Kristo wrote: >>> Hi Santosh, >>> >>> This series contains a few fixes for the TI SCI clock driver. >>> - Patch #1 is a clear bug fix, where we missed to parse assigned-clock >>> data properly to detect which clocks are in use on the SoC. >>> - Patch #2 is a performance improvement patch which avoids some >>> unnecessary round trips to firmware side while setting clock >>> frequency. >>> - Patch #3 fixes some issues with set_rate passed to firmware, where the >>> parameters are too strict; namely, firmware fails to handle some cases >>> properly if min,tgt,max values for a clock rate are exactly the same >>> value. Yeah, the firmware is quite weird here but nothing much else we >>> can do from kernel side other than this.... >>> >> Looks fine to me Tero. >> >> Acked-by: Santosh Shilimkar <ssantosh@kernel.org> >> >> >> Hi Stephen, Mike, >> Can you please pick these fixes via clk tree ? > > Sure. I assume this is -next material and not critical fixes. > Yep.