diff mbox series

[08/24] xfs: replace open-coded calls to xfs_logprint with helpers

Message ID 160013422703.2923511.4608245885181531356.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series fstests: tons of random fixes | expand

Commit Message

Darrick J. Wong Sept. 15, 2020, 1:43 a.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

Use the test/scratch xfs_logprint helpers.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/135 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zorro Lang Sept. 16, 2020, 2:35 a.m. UTC | #1
On Mon, Sep 14, 2020 at 06:43:47PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Use the test/scratch xfs_logprint helpers.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/xfs/135 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/tests/xfs/135 b/tests/xfs/135
> index cc505980..9783cfc2 100755
> --- a/tests/xfs/135
> +++ b/tests/xfs/135
> @@ -48,7 +48,7 @@ for i in 16 32 64 128 256; do
>  	_scratch_xfs_db -x -c "logformat -c 3 -s $lsunit" | \
>  		tee -a $seqres.full
>  	# don't redirect error output so it causes test failure
> -	$XFS_LOGPRINT_PROG $SCRATCH_DEV >> $seqres.full
> +	_scratch_xfs_logprint >> $seqres.full
>  done
>  
>  # success, all done
>
Christoph Hellwig Sept. 17, 2020, 7:54 a.m. UTC | #2
On Mon, Sep 14, 2020 at 06:43:47PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Use the test/scratch xfs_logprint helpers.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/xfs/135 b/tests/xfs/135
index cc505980..9783cfc2 100755
--- a/tests/xfs/135
+++ b/tests/xfs/135
@@ -48,7 +48,7 @@  for i in 16 32 64 128 256; do
 	_scratch_xfs_db -x -c "logformat -c 3 -s $lsunit" | \
 		tee -a $seqres.full
 	# don't redirect error output so it causes test failure
-	$XFS_LOGPRINT_PROG $SCRATCH_DEV >> $seqres.full
+	_scratch_xfs_logprint >> $seqres.full
 done
 
 # success, all done