| Message ID | 20200917081049.27428-3-osalvador@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | HWpoison: further fixes and cleanups | expand |
On Thu, Sep 17, 2020 at 10:10:44AM +0200, Oscar Salvador wrote: > Aristeu Rozanski reported that some hwpoison tests > were returning -EBUSY while before the rework they succeed [1] [2]. > > The root case is that during a rebase, the call to page_handle_poison was > setting hugepage_or_freepage = true unconditionally from __soft_offline_page. > > Aristeu said that after this fix, everything works. > > [1] https://patchwork.kernel.org/comment/23617301/ > [2] https://patchwork.kernel.org/comment/23619535/ > > Signed-off-by: Oscar Salvador <osalvador@suse.de> > Reported-by: Aristeu Rozanski <aris@ruivo.org> Tested-by: Aristeu Rozanski <aris@ruivo.org>
diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 74a53881f94b..db61bdee9734 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1852,7 +1852,7 @@ static int __soft_offline_page(struct page *page) if (!ret) { bool release = !huge; - if (!page_handle_poison(page, true, release)) + if (!page_handle_poison(page, huge, release)) ret = -EBUSY; } else { if (!list_empty(&pagelist))
Aristeu Rozanski reported that some hwpoison tests were returning -EBUSY while before the rework they succeed [1] [2]. The root case is that during a rebase, the call to page_handle_poison was setting hugepage_or_freepage = true unconditionally from __soft_offline_page. Aristeu said that after this fix, everything works. [1] https://patchwork.kernel.org/comment/23617301/ [2] https://patchwork.kernel.org/comment/23619535/ Signed-off-by: Oscar Salvador <osalvador@suse.de> Reported-by: Aristeu Rozanski <aris@ruivo.org> --- mm/memory-failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)