| Message ID | 20200810134252.68614-1-alexandru.ardelean@analog.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | clk: axi-clk-gen: misc updates to the driver | expand |
These patches synchronize the driver with the current state in the Analog Devices Linux tree: https://github.com/analogdevicesinc/linux/ They have been in the tree for about 2-3, so they did receive some testing. Highlights are: * Add support for fractional dividers (Lars-Peter Clausen) * Enable support for ZynqMP (UltraScale) (Dragos Bogdan) * Support frequency limits for ZynqMP (Mathias Tausen) - And continued by Mircea Caprioru, to read them from the IP cores Changelog v1 -> v2: - in patch 'include: fpga: adi-axi-common.h: add definitions for supported FPGAs' * converted enums to #define * added Intel FPGA definitions * added Device-Package definitions * added INTEL / XILINX in the define names definitions according to: https://github.com/analogdevicesinc/hdl/blob/4e438261aa319b1dda4c593c155218a93b1d869b/library/scripts/adi_intel_device_info_enc.tcl https://github.com/analogdevicesinc/hdl/blob/4e438261aa319b1dda4c593c155218a93b1d869b/library/scripts/adi_xilinx_device_info_enc.tcl Dragos Bogdan (1): clk: axi-clkgen: add support for ZynqMP (UltraScale) Lars-Peter Clausen (2): clk: axi-clkgen: Add support for fractional dividers clk: axi-clkgen: Set power bits for fractional mode Mathias Tausen (1): clk: axi-clkgen: Respect ZYNQMP PFD/VCO frequency limits Mircea Caprioru (2): include: fpga: adi-axi-common.h: add definitions for supported FPGAs clk: axi-clkgen: Add support for FPGA info drivers/clk/Kconfig | 2 +- drivers/clk/clk-axi-clkgen.c | 253 ++++++++++++++++++++++------ include/linux/fpga/adi-axi-common.h | 103 +++++++++++ 3 files changed, 302 insertions(+), 56 deletions(-)
On Mon, Aug 10, 2020 at 4:41 PM Alexandru Ardelean <alexandru.ardelean@analog.com> wrote: > > These patches synchronize the driver with the current state in the > Analog Devices Linux tree: > https://github.com/analogdevicesinc/linux/ > > They have been in the tree for about 2-3, so they did receive some > testing. Ping on this series. Do I need to do a re-send? > > Highlights are: > * Add support for fractional dividers (Lars-Peter Clausen) > * Enable support for ZynqMP (UltraScale) (Dragos Bogdan) > * Support frequency limits for ZynqMP (Mathias Tausen) > - And continued by Mircea Caprioru, to read them from the IP cores > > Changelog v1 -> v2: > - in patch 'include: fpga: adi-axi-common.h: add definitions for supported FPGAs' > * converted enums to #define > * added Intel FPGA definitions > * added Device-Package definitions > * added INTEL / XILINX in the define names > definitions according to: > https://github.com/analogdevicesinc/hdl/blob/4e438261aa319b1dda4c593c155218a93b1d869b/library/scripts/adi_intel_device_info_enc.tcl > https://github.com/analogdevicesinc/hdl/blob/4e438261aa319b1dda4c593c155218a93b1d869b/library/scripts/adi_xilinx_device_info_enc.tcl > > Dragos Bogdan (1): > clk: axi-clkgen: add support for ZynqMP (UltraScale) > > Lars-Peter Clausen (2): > clk: axi-clkgen: Add support for fractional dividers > clk: axi-clkgen: Set power bits for fractional mode > > Mathias Tausen (1): > clk: axi-clkgen: Respect ZYNQMP PFD/VCO frequency limits > > Mircea Caprioru (2): > include: fpga: adi-axi-common.h: add definitions for supported FPGAs > clk: axi-clkgen: Add support for FPGA info > > drivers/clk/Kconfig | 2 +- > drivers/clk/clk-axi-clkgen.c | 253 ++++++++++++++++++++++------ > include/linux/fpga/adi-axi-common.h | 103 +++++++++++ > 3 files changed, 302 insertions(+), 56 deletions(-) > > -- > 2.17.1 >
On Mon, Sep 14, 2020 at 11:11:05AM +0300, Alexandru Ardelean wrote: > On Mon, Aug 10, 2020 at 4:41 PM Alexandru Ardelean > <alexandru.ardelean@analog.com> wrote: > > > > These patches synchronize the driver with the current state in the > > Analog Devices Linux tree: > > https://github.com/analogdevicesinc/linux/ > > > > They have been in the tree for about 2-3, so they did receive some > > testing. > > Ping on this series. > Do I need to do a re-send? I've applied the FPGA one, the other ones should go through the clock tree I think? > > > > > Highlights are: > > * Add support for fractional dividers (Lars-Peter Clausen) > > * Enable support for ZynqMP (UltraScale) (Dragos Bogdan) > > * Support frequency limits for ZynqMP (Mathias Tausen) > > - And continued by Mircea Caprioru, to read them from the IP cores > > > > Changelog v1 -> v2: > > - in patch 'include: fpga: adi-axi-common.h: add definitions for supported FPGAs' > > * converted enums to #define > > * added Intel FPGA definitions > > * added Device-Package definitions > > * added INTEL / XILINX in the define names > > definitions according to: > > https://github.com/analogdevicesinc/hdl/blob/4e438261aa319b1dda4c593c155218a93b1d869b/library/scripts/adi_intel_device_info_enc.tcl > > https://github.com/analogdevicesinc/hdl/blob/4e438261aa319b1dda4c593c155218a93b1d869b/library/scripts/adi_xilinx_device_info_enc.tcl > > > > Dragos Bogdan (1): > > clk: axi-clkgen: add support for ZynqMP (UltraScale) > > > > Lars-Peter Clausen (2): > > clk: axi-clkgen: Add support for fractional dividers > > clk: axi-clkgen: Set power bits for fractional mode > > > > Mathias Tausen (1): > > clk: axi-clkgen: Respect ZYNQMP PFD/VCO frequency limits > > > > Mircea Caprioru (2): > > include: fpga: adi-axi-common.h: add definitions for supported FPGAs > > clk: axi-clkgen: Add support for FPGA info > > > > drivers/clk/Kconfig | 2 +- > > drivers/clk/clk-axi-clkgen.c | 253 ++++++++++++++++++++++------ > > include/linux/fpga/adi-axi-common.h | 103 +++++++++++ > > 3 files changed, 302 insertions(+), 56 deletions(-) > > > > -- > > 2.17.1 > > Thanks, Moritz
Quoting Moritz Fischer (2020-09-14 19:41:38) > On Mon, Sep 14, 2020 at 11:11:05AM +0300, Alexandru Ardelean wrote: > > On Mon, Aug 10, 2020 at 4:41 PM Alexandru Ardelean > > <alexandru.ardelean@analog.com> wrote: > > > > > > These patches synchronize the driver with the current state in the > > > Analog Devices Linux tree: > > > https://github.com/analogdevicesinc/linux/ > > > > > > They have been in the tree for about 2-3, so they did receive some > > > testing. > > > > Ping on this series. > > Do I need to do a re-send? I got this patch series twice. Not sure why. > > I've applied the FPGA one, the other ones should go through the clock > tree I think? Doesn't patch 6 rely on the FPGA patch? How can that driver build without the header file?
On Tue, Sep 22, 2020 at 10:42 PM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Moritz Fischer (2020-09-14 19:41:38) > > On Mon, Sep 14, 2020 at 11:11:05AM +0300, Alexandru Ardelean wrote: > > > On Mon, Aug 10, 2020 at 4:41 PM Alexandru Ardelean > > > <alexandru.ardelean@analog.com> wrote: > > > > > > > > These patches synchronize the driver with the current state in the > > > > Analog Devices Linux tree: > > > > https://github.com/analogdevicesinc/linux/ > > > > > > > > They have been in the tree for about 2-3, so they did receive some > > > > testing. > > > > > > Ping on this series. > > > Do I need to do a re-send? > > I got this patch series twice. Not sure why. My fault here. Some Ctrl + R usage and not being attentive with the arguments. I think I added "*.patch" twice on the send-mail command. I did something similar [by accident] for some DMA patches. Apologies. I can do a re-send for this, if it helps. > > > > > I've applied the FPGA one, the other ones should go through the clock > > tree I think? > > Doesn't patch 6 rely on the FPGA patch? How can that driver build > without the header file? Yes it does depend on the FPGA patch. We can drop patch 6 for now, pending a merge to Linus' tree and then wait for the trickle-down. I don't mind waiting for these patches. I have plenty of backlog that I want to run through, and cleanup and then upstream. So, there is no hurry.
Quoting Alexandru Ardelean (2020-09-22 23:22:33) > On Tue, Sep 22, 2020 at 10:42 PM Stephen Boyd <sboyd@kernel.org> wrote: > > > > Quoting Moritz Fischer (2020-09-14 19:41:38) > > > On Mon, Sep 14, 2020 at 11:11:05AM +0300, Alexandru Ardelean wrote: > > > > On Mon, Aug 10, 2020 at 4:41 PM Alexandru Ardelean > > > > <alexandru.ardelean@analog.com> wrote: > > > > > > > > > > These patches synchronize the driver with the current state in the > > > > > Analog Devices Linux tree: > > > > > https://github.com/analogdevicesinc/linux/ > > > > > > > > > > They have been in the tree for about 2-3, so they did receive some > > > > > testing. > > > > > > > > Ping on this series. > > > > Do I need to do a re-send? > > > > I got this patch series twice. Not sure why. > > My fault here. > Some Ctrl + R usage and not being attentive with the arguments. > I think I added "*.patch" twice on the send-mail command. > I did something similar [by accident] for some DMA patches. > Apologies. > > I can do a re-send for this, if it helps. Sure. Please resend it. > > > > > > > > > I've applied the FPGA one, the other ones should go through the clock > > > tree I think? > > > > Doesn't patch 6 rely on the FPGA patch? How can that driver build > > without the header file? > > Yes it does depend on the FPGA patch. > We can drop patch 6 for now, pending a merge to Linus' tree and then > wait for the trickle-down. > I don't mind waiting for these patches. > I have plenty of backlog that I want to run through, and cleanup and > then upstream. > So, there is no hurry. Can you send me a signed tag with that patch? I can base this patch series on top of that. Or I can just apply it to clk tree and if nobody changes it in the meantime merge should work out in linux-next and linus' tree upstream.
Hi Stephen, On Wed, Sep 23, 2020 at 04:58:33PM -0700, Stephen Boyd wrote: > Quoting Alexandru Ardelean (2020-09-22 23:22:33) > > On Tue, Sep 22, 2020 at 10:42 PM Stephen Boyd <sboyd@kernel.org> wrote: > > > > > > Quoting Moritz Fischer (2020-09-14 19:41:38) > > > > On Mon, Sep 14, 2020 at 11:11:05AM +0300, Alexandru Ardelean wrote: > > > > > On Mon, Aug 10, 2020 at 4:41 PM Alexandru Ardelean > > > > > <alexandru.ardelean@analog.com> wrote: > > > > > > > > > > > > These patches synchronize the driver with the current state in the > > > > > > Analog Devices Linux tree: > > > > > > https://github.com/analogdevicesinc/linux/ > > > > > > > > > > > > They have been in the tree for about 2-3, so they did receive some > > > > > > testing. > > > > > > > > > > Ping on this series. > > > > > Do I need to do a re-send? > > > > > > I got this patch series twice. Not sure why. > > > > My fault here. > > Some Ctrl + R usage and not being attentive with the arguments. > > I think I added "*.patch" twice on the send-mail command. > > I did something similar [by accident] for some DMA patches. > > Apologies. > > > > I can do a re-send for this, if it helps. > > Sure. Please resend it. > > > > > > > > > > > > > > I've applied the FPGA one, the other ones should go through the clock > > > > tree I think? > > > > > > Doesn't patch 6 rely on the FPGA patch? How can that driver build > > > without the header file? > > > > Yes it does depend on the FPGA patch. > > We can drop patch 6 for now, pending a merge to Linus' tree and then > > wait for the trickle-down. > > I don't mind waiting for these patches. > > I have plenty of backlog that I want to run through, and cleanup and > > then upstream. > > So, there is no hurry. > > Can you send me a signed tag with that patch? I can base this patch > series on top of that. Or I can just apply it to clk tree and if nobody > changes it in the meantime merge should work out in linux-next and > linus' tree upstream. Long story short I messed up my pull-request to Greg and had to back out the patch anyways. In retrospect I think the patch should have gone through your tree anyways, so here's our chance to get it right. Feel free to take it with the rest of the changes through your tree. Note: When I applied the patch I fixed up the whitespace that checkpatch complained about so you might want to do that (or ask Alexandru to resend the patch). Acked-by: Moritz Fischer <mdf@kernel.org> Sorry for the confusion and let me know if you still prefer a signed tag. - Moritz
On Thu, Sep 24, 2020 at 7:53 AM Moritz Fischer <mdf@kernel.org> wrote: > > Hi Stephen, > > On Wed, Sep 23, 2020 at 04:58:33PM -0700, Stephen Boyd wrote: > > Quoting Alexandru Ardelean (2020-09-22 23:22:33) > > > On Tue, Sep 22, 2020 at 10:42 PM Stephen Boyd <sboyd@kernel.org> wrote: > > > > > > > > Quoting Moritz Fischer (2020-09-14 19:41:38) > > > > > On Mon, Sep 14, 2020 at 11:11:05AM +0300, Alexandru Ardelean wrote: > > > > > > On Mon, Aug 10, 2020 at 4:41 PM Alexandru Ardelean > > > > > > <alexandru.ardelean@analog.com> wrote: > > > > > > > > > > > > > > These patches synchronize the driver with the current state in the > > > > > > > Analog Devices Linux tree: > > > > > > > https://github.com/analogdevicesinc/linux/ > > > > > > > > > > > > > > They have been in the tree for about 2-3, so they did receive some > > > > > > > testing. > > > > > > > > > > > > Ping on this series. > > > > > > Do I need to do a re-send? > > > > > > > > I got this patch series twice. Not sure why. > > > > > > My fault here. > > > Some Ctrl + R usage and not being attentive with the arguments. > > > I think I added "*.patch" twice on the send-mail command. > > > I did something similar [by accident] for some DMA patches. > > > Apologies. > > > > > > I can do a re-send for this, if it helps. > > > > Sure. Please resend it. > > > > > > > > > > > > > > > > > > > I've applied the FPGA one, the other ones should go through the clock > > > > > tree I think? > > > > > > > > Doesn't patch 6 rely on the FPGA patch? How can that driver build > > > > without the header file? > > > > > > Yes it does depend on the FPGA patch. > > > We can drop patch 6 for now, pending a merge to Linus' tree and then > > > wait for the trickle-down. > > > I don't mind waiting for these patches. > > > I have plenty of backlog that I want to run through, and cleanup and > > > then upstream. > > > So, there is no hurry. > > > > Can you send me a signed tag with that patch? I can base this patch > > series on top of that. Or I can just apply it to clk tree and if nobody > > changes it in the meantime merge should work out in linux-next and > > linus' tree upstream. > > Long story short I messed up my pull-request to Greg and had to back out > the patch anyways. In retrospect I think the patch should have gone > through your tree anyways, so here's our chance to get it right. > > Feel free to take it with the rest of the changes through your tree. > > Note: When I applied the patch I fixed up the whitespace that checkpatch > complained about so you might want to do that (or ask Alexandru to > resend the patch). > I'll fixup the checkpatch stuff, re-send as a V3, and add your Acked-by. Thanks & apologies for the mess-up on my part. > Acked-by: Moritz Fischer <mdf@kernel.org> > > Sorry for the confusion and let me know if you still prefer a signed > tag. > > - Moritz