mbox series

[v3,0/2] Use the new usb control message API.

Message ID 20200926091327.8021-1-petkan@nucleusys.com (mailing list archive)
Headers show
Series Use the new usb control message API. | expand

Message

Petko Manolov Sept. 26, 2020, 9:13 a.m. UTC
From: Petko Manolov <petko.manolov@konsulko.com>

Open coding, ccasional improper error handling by the caller of
usb_control_msg() and not flagging partial read as an error requires a new API
that takes care of these issues.  It took the form of
usb_control_msg_send/recv() and this patch series is converting Pegasus and
RTL8150 drivers to using the proper calls.

Petko Manolov (2):
  net: pegasus: Use the new usb control message API.
  net: rtl8150: Use the new usb control message API.

 drivers/net/usb/pegasus.c | 61 ++++++++++-----------------------------
 drivers/net/usb/rtl8150.c | 32 ++++----------------
 2 files changed, 21 insertions(+), 72 deletions(-)

Comments

Greg Kroah-Hartman Sept. 27, 2020, 10:16 a.m. UTC | #1
On Sat, Sep 26, 2020 at 12:13:25PM +0300, Petko Manolov wrote:
> From: Petko Manolov <petko.manolov@konsulko.com>
> 
> Open coding, ccasional improper error handling by the caller of
> usb_control_msg() and not flagging partial read as an error requires a new API
> that takes care of these issues.  It took the form of
> usb_control_msg_send/recv() and this patch series is converting Pegasus and
> RTL8150 drivers to using the proper calls.
> 
> Petko Manolov (2):
>   net: pegasus: Use the new usb control message API.
>   net: rtl8150: Use the new usb control message API.
> 
>  drivers/net/usb/pegasus.c | 61 ++++++++++-----------------------------
>  drivers/net/usb/rtl8150.c | 32 ++++----------------
>  2 files changed, 21 insertions(+), 72 deletions(-)

Normally drivers/net/ stuff gets sent to the netdev mailing list.

I don't want to take patches that those maintainers/developers have not
seen and acked yet, so can you resend this series and also cc: them?

thanks,

greg k-h
Petko Manolov Sept. 27, 2020, 12:56 p.m. UTC | #2
On 20-09-27 12:16:31, Greg KH wrote:
> On Sat, Sep 26, 2020 at 12:13:25PM +0300, Petko Manolov wrote:
> > From: Petko Manolov <petko.manolov@konsulko.com>
> > 
> > Open coding, ccasional improper error handling by the caller of 
> > usb_control_msg() and not flagging partial read as an error requires a new 
> > API that takes care of these issues.  It took the form of 
> > usb_control_msg_send/recv() and this patch series is converting Pegasus and 
> > RTL8150 drivers to using the proper calls.
> > 
> > Petko Manolov (2): net: pegasus: Use the new usb control message API. net: 
> >   rtl8150: Use the new usb control message API.
> > 
> >  drivers/net/usb/pegasus.c | 61 ++++++++++----------------------------- 
> >  drivers/net/usb/rtl8150.c | 32 ++++---------------- 2 files changed, 21 
> >  insertions(+), 72 deletions(-)
> 
> Normally drivers/net/ stuff gets sent to the netdev mailing list.
> 
> I don't want to take patches that those maintainers/developers have not seen 
> and acked yet, so can you resend this series and also cc: them?

The changes are entirely in the USB land and thus unrelated to the networking 
part of the driver.  However, getting their ack is perhaps the right thing to do 
so i just followed your advice. :)


cheers,
Petko