| Message ID | 20200917065949.3476-1-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | usb: dwc-meson-g12a: Add support for USB on S400 board | expand |
On 17/09/2020 08:59, Neil Armstrong wrote: > The Amlogic AXG is close to the GXL Glue but with a single OTG PHY. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Reviewed-by: Kevin Hilman <khilman@baylibre.com> > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Forgot: Reviewed-by: Rob Herring <robh@kernel.org> Neil > --- > .../usb/amlogic,meson-g12a-usb-ctrl.yaml | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > index 5b04a7dfa018..c0058332b967 100644 > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > @@ -25,13 +25,14 @@ description: | > The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in > host-only mode. > > - The Amlogic GXL & GXM SoCs doesn't embed an USB3 PHY. > + The Amlogic GXL, GXM & AXG SoCs doesn't embed an USB3 PHY. > > properties: > compatible: > enum: > - amlogic,meson-gxl-usb-ctrl > - amlogic,meson-gxm-usb-ctrl > + - amlogic,meson-axg-usb-ctrl > - amlogic,meson-g12a-usb-ctrl > - amlogic,meson-a1-usb-ctrl > > @@ -151,6 +152,25 @@ allOf: > > required: > - clock-names > + - if: > + properties: > + compatible: > + enum: > + - amlogic,meson-axg-usb-ctrl > + > + then: > + properties: > + phy-names: > + items: > + - const: usb2-phy1 # USB2 PHY1 if USBOTG_B port is used > + clocks: > + minItems: 2 > + clock-names: > + items: > + - const: usb_ctrl > + - const: ddr > + required: > + - clock-names > - if: > properties: > compatible: >
Hi Felipe, Is there anything to change in this serie ? Thanks, Neil On 17/09/2020 08:59, Neil Armstrong wrote: > The Amlogic AXG is close to the GXL Glue but with a single OTG PHY. > > It needs the same init sequence as GXL & GXM, but it seems it doesn't need > the host disconnect bit. > > The Glue driver reuses the already implemented GXL & GXM work. > > The USB2 PHY driver needs a slight tweak to keep the OTG detection working. > > Changes since v1 at [1]: > - s/close from/close to/g > - collected review tags > - added small comment about phy management in patch 3 > - removed status = "okay" in patch 4 > - removed invalid phy-supply of phy1 in patch 5 > > [1] http://lore.kernel.org/r/20200909160409.8678-1-narmstrong@baylibre.com > > Neil Armstrong (5): > phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode > dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG > Families USB Glue Bindings > usb: dwc-meson-g12a: Add support for USB on AXG SoCs > arm64: dts: meson-axg: add USB nodes > arm64: dts: meson-axg-s400: enable USB OTG > > .../usb/amlogic,meson-g12a-usb-ctrl.yaml | 22 +++++++- > .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 6 +++ > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 50 +++++++++++++++++++ > drivers/phy/amlogic/phy-meson-gxl-usb2.c | 3 +- > drivers/usb/dwc3/dwc3-meson-g12a.c | 18 +++++++ > 5 files changed, 97 insertions(+), 2 deletions(-) >
Neil Armstrong <narmstrong@baylibre.com> writes: > Hi Felipe, > > Is there anything to change in this serie ? I've been waiting for Kishon's review of drivers/phy parts. I can take the rest, but without Kishon's ack, drivers/phy will be left out.
On 29/09/2020 12:33, Felipe Balbi wrote: > Neil Armstrong <narmstrong@baylibre.com> writes: > >> Hi Felipe, >> >> Is there anything to change in this serie ? > > I've been waiting for Kishon's review of drivers/phy parts. I can take > the rest, but without Kishon's ack, drivers/phy will be left out. > No problem, please go ahead and take the rest, I'll re-submit the phy change again if Kishon wants some changes. Thanks, Neil
Hi Kevin, On 17/09/2020 08:59, Neil Armstrong wrote: > The Amlogic AXG is close to the GXL Glue but with a single OTG PHY. > > It needs the same init sequence as GXL & GXM, but it seems it doesn't need > the host disconnect bit. > > The Glue driver reuses the already implemented GXL & GXM work. > > The USB2 PHY driver needs a slight tweak to keep the OTG detection working. > > Changes since v1 at [1]: > - s/close from/close to/g > - collected review tags > - added small comment about phy management in patch 3 > - removed status = "okay" in patch 4 > - removed invalid phy-supply of phy1 in patch 5 > > [1] http://lore.kernel.org/r/20200909160409.8678-1-narmstrong@baylibre.com > > Neil Armstrong (5): > phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode > dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG > Families USB Glue Bindings > usb: dwc-meson-g12a: Add support for USB on AXG SoCs > arm64: dts: meson-axg: add USB nodes > arm64: dts: meson-axg-s400: enable USB OTG Can you pick the DT patches ? Thanks, Neil > > .../usb/amlogic,meson-g12a-usb-ctrl.yaml | 22 +++++++- > .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 6 +++ > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 50 +++++++++++++++++++ > drivers/phy/amlogic/phy-meson-gxl-usb2.c | 3 +- > drivers/usb/dwc3/dwc3-meson-g12a.c | 18 +++++++ > 5 files changed, 97 insertions(+), 2 deletions(-) >
Neil Armstrong <narmstrong@baylibre.com> writes: > Hi Kevin, > > On 17/09/2020 08:59, Neil Armstrong wrote: >> The Amlogic AXG is close to the GXL Glue but with a single OTG PHY. >> >> It needs the same init sequence as GXL & GXM, but it seems it doesn't need >> the host disconnect bit. >> >> The Glue driver reuses the already implemented GXL & GXM work. >> >> The USB2 PHY driver needs a slight tweak to keep the OTG detection working. >> >> Changes since v1 at [1]: >> - s/close from/close to/g >> - collected review tags >> - added small comment about phy management in patch 3 >> - removed status = "okay" in patch 4 >> - removed invalid phy-supply of phy1 in patch 5 >> >> [1] http://lore.kernel.org/r/20200909160409.8678-1-narmstrong@baylibre.com >> >> Neil Armstrong (5): >> phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode >> dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG >> Families USB Glue Bindings >> usb: dwc-meson-g12a: Add support for USB on AXG SoCs >> arm64: dts: meson-axg: add USB nodes >> arm64: dts: meson-axg-s400: enable USB OTG > > Can you pick the DT patches ? Yes, queued up. Since we're already at -rc7, this may not make it until v5.11. Kevin
The Amlogic AXG is close to the GXL Glue but with a single OTG PHY. It needs the same init sequence as GXL & GXM, but it seems it doesn't need the host disconnect bit. The Glue driver reuses the already implemented GXL & GXM work. The USB2 PHY driver needs a slight tweak to keep the OTG detection working. Changes since v1 at [1]: - s/close from/close to/g - collected review tags - added small comment about phy management in patch 3 - removed status = "okay" in patch 4 - removed invalid phy-supply of phy1 in patch 5 [1] http://lore.kernel.org/r/20200909160409.8678-1-narmstrong@baylibre.com Neil Armstrong (5): phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings usb: dwc-meson-g12a: Add support for USB on AXG SoCs arm64: dts: meson-axg: add USB nodes arm64: dts: meson-axg-s400: enable USB OTG .../usb/amlogic,meson-g12a-usb-ctrl.yaml | 22 +++++++- .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 6 +++ arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 50 +++++++++++++++++++ drivers/phy/amlogic/phy-meson-gxl-usb2.c | 3 +- drivers/usb/dwc3/dwc3-meson-g12a.c | 18 +++++++ 5 files changed, 97 insertions(+), 2 deletions(-)