| Message ID | 1600771612-30727-2-git-send-email-jun.li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | add NXP imx8mp usb support | expand |
On Tue, Sep 22, 2020 at 06:46:47PM +0800, Li Jun wrote: > Add a property "xhci-64bit-support-disable" to disable xhci 64bit address > dma, some SoC integration may not support 64bit DMA but the AC64 bit > (bit 0) of HCCPARAMS1 is kept to be 1. Use 'dma-ranges' for this. > Signed-off-by: Li Jun <jun.li@nxp.com> > --- > Documentation/devicetree/bindings/usb/usb-xhci.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt > index 0c5cff8..26446fb 100644 > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt > @@ -28,6 +28,9 @@ Optional properties: > - quirk-broken-port-ped: set if the controller has broken port disable mechanism > - imod-interval-ns: default interrupt moderation interval is 5000ns > - phys : see usb-hcd.yaml in the current directory > + - xhci-64bit-support-disable: set if the AC64 bit (bit 0) of HCCPARAMS1 is > + set to be 1, but the controller actually can't handle 64-bit address > + due to SoC integration. > > additionally the properties from usb-hcd.yaml (in the current directory) are > supported. > -- > 2.7.4 >
Hi Rob, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Wednesday, September 30, 2020 2:11 AM > To: Jun Li <jun.li@nxp.com> > Cc: shawnguo@kernel.org; balbi@kernel.org; mathias.nyman@intel.com; > gregkh@linuxfoundation.org; s.hauer@pengutronix.de; > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > <linux-imx@nxp.com>; Anson Huang <anson.huang@nxp.com>; Aisheng Dong > <aisheng.dong@nxp.com>; Peng Fan <peng.fan@nxp.com>; Andy Duan > <fugang.duan@nxp.com>; Joakim Zhang <qiangqing.zhang@nxp.com>; Horia > Geanta <horia.geanta@nxp.com>; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v3 1/6] dt-bindings: usb: xhci: add property to disable > xhci 64bit support > > On Tue, Sep 22, 2020 at 06:46:47PM +0800, Li Jun wrote: > > Add a property "xhci-64bit-support-disable" to disable xhci 64bit > > address dma, some SoC integration may not support 64bit DMA but the > > AC64 bit (bit 0) of HCCPARAMS1 is kept to be 1. > > Use 'dma-ranges' for this. Thanks, sent out v4 with dma-ranges property approach. Li Jun > > > Signed-off-by: Li Jun <jun.li@nxp.com> > > --- > > Documentation/devicetree/bindings/usb/usb-xhci.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt > > b/Documentation/devicetree/bindings/usb/usb-xhci.txt > > index 0c5cff8..26446fb 100644 > > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt > > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt > > @@ -28,6 +28,9 @@ Optional properties: > > - quirk-broken-port-ped: set if the controller has broken port disable > mechanism > > - imod-interval-ns: default interrupt moderation interval is 5000ns > > - phys : see usb-hcd.yaml in the current directory > > + - xhci-64bit-support-disable: set if the AC64 bit (bit 0) of HCCPARAMS1 > is > > + set to be 1, but the controller actually can't handle 64-bit address > > + due to SoC integration. > > > > additionally the properties from usb-hcd.yaml (in the current > > directory) are supported. > > -- > > 2.7.4 > >
diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt index 0c5cff8..26446fb 100644 --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt @@ -28,6 +28,9 @@ Optional properties: - quirk-broken-port-ped: set if the controller has broken port disable mechanism - imod-interval-ns: default interrupt moderation interval is 5000ns - phys : see usb-hcd.yaml in the current directory + - xhci-64bit-support-disable: set if the AC64 bit (bit 0) of HCCPARAMS1 is + set to be 1, but the controller actually can't handle 64-bit address + due to SoC integration. additionally the properties from usb-hcd.yaml (in the current directory) are supported.
Add a property "xhci-64bit-support-disable" to disable xhci 64bit address dma, some SoC integration may not support 64bit DMA but the AC64 bit (bit 0) of HCCPARAMS1 is kept to be 1. Signed-off-by: Li Jun <jun.li@nxp.com> --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 3 +++ 1 file changed, 3 insertions(+)