[v2,0/2] ALSA: HDA: Early Forbid of runtime PM

Message

Kai Vehmanen Sept. 30, 2020, 11:41 a.m. UTC

Fix a race with runtime PM enabled during codec initialization.

For snd-hda-intel, no changes are needed in controller code, but
to not break ASoC controller drivers, this V2 series adds
an additional change in ASoC hdac_hda to allow runtime pm again
at end of probe.

Harsha Priya (1):
  ALSA: HDA: Early Forbid of runtime PM

Kai Vehmanen (1):
  ASoC: hdac_hda: allow runtime pm at end of probe

 sound/pci/hda/hda_codec.c   | 3 +++
 sound/soc/codecs/hdac_hda.c | 3 +++
 2 files changed, 6 insertions(+)

Comments

Kai Vehmanen Sept. 30, 2020, 12:05 p.m. UTC | #1

Hi,

On Wed, 30 Sep 2020, Kai Vehmanen wrote:

> Fix a race with runtime PM enabled during codec initialization.
> 
> For snd-hda-intel, no changes are needed in controller code, but
> to not break ASoC controller drivers, this V2 series adds
> an additional change in ASoC hdac_hda to allow runtime pm again
> at end of probe.

this is a follow-up to:
https://mailman.alsa-project.org/pipermail/alsa-devel/2020-August/173141.html

It turns out we need to make changes both in ASoC and sound/hda at the 
same time, to not break anything. So again a case where either Takashi or 
Mark, you should take both at the same time, if code itself is ok to all.

PS And sorry, versioning is confusing, should have sent this as V3.
   V1 modified only realtek codec, V2 modified hda_codec.c part and
   this V3 adds a patch to ASoC hdac_hdmi.c.

Br, Kai

Takashi Iwai Sept. 30, 2020, 2:14 p.m. UTC | #2

On Wed, 30 Sep 2020 14:05:01 +0200,
Kai Vehmanen wrote:
> 
> Hi,
> 
> On Wed, 30 Sep 2020, Kai Vehmanen wrote:
> 
> > Fix a race with runtime PM enabled during codec initialization.
> > 
> > For snd-hda-intel, no changes are needed in controller code, but
> > to not break ASoC controller drivers, this V2 series adds
> > an additional change in ASoC hdac_hda to allow runtime pm again
> > at end of probe.
> 
> this is a follow-up to:
> https://mailman.alsa-project.org/pipermail/alsa-devel/2020-August/173141.html
> 
> It turns out we need to make changes both in ASoC and sound/hda at the 
> same time, to not break anything. So again a case where either Takashi or 
> Mark, you should take both at the same time, if code itself is ok to all.

I'm fine to take into my tree if Mark can give an Ack.


thanks,

Takashi

Takashi Iwai Sept. 30, 2020, 3:06 p.m. UTC | #3

On Wed, 30 Sep 2020 13:41:38 +0200,
Kai Vehmanen wrote:
> 
> Fix a race with runtime PM enabled during codec initialization.
> 
> For snd-hda-intel, no changes are needed in controller code, but
> to not break ASoC controller drivers, this V2 series adds
> an additional change in ASoC hdac_hda to allow runtime pm again
> at end of probe.
> 
> Harsha Priya (1):
>   ALSA: HDA: Early Forbid of runtime PM
> 
> Kai Vehmanen (1):
>   ASoC: hdac_hda: allow runtime pm at end of probe

Applied both patches now to for-linus branch.

I'm not sure whether I'm going to send a pull request for 5.9-final,
but certainly those will be included in 5.10-rc1.


thanks,

Takashi