| Message ID | 20200923114419.71218-1-songmuchun@bytedance.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | io_uring: Fix async workqueue is not canceled on some corner case | expand |
Ping guys. This is worth fixing. On Wed, Sep 23, 2020 at 7:44 PM Muchun Song <songmuchun@bytedance.com> wrote: > > We should make sure that async workqueue is canceled on exit, but on > some corner case, we found that the async workqueue is not canceled > on exit in the linux-5.4. So we started an in-depth investigation. > Fortunately, we finally found the problem. The commit: > > 1c4404efcf2c ("io_uring: make sure async workqueue is canceled on exit") > > did not completely solve this problem. This patch series to solve this > problem completely. And there's no upstream variant of this commit, so > this patch series is just fix the linux-5.4.y stable branch. > > changelog in v2: > 1. Fix missing save the current thread files > 2. Fix double list add in io_queue_async_work() > > Muchun Song (4): > io_uring: Fix missing smp_mb() in io_cancel_async_work() > io_uring: Fix remove irrelevant req from the task_list > io_uring: Fix missing save the current thread files > io_uring: Fix double list add in io_queue_async_work() > > Yinyin Zhu (1): > io_uring: Fix resource leaking when kill the process > > fs/io_uring.c | 59 +++++++++++++++++++++++++++++++++++++++-------------------- > 1 file changed, 39 insertions(+), 20 deletions(-) > > -- > 2.11.0 >
On 9/28/20 6:50 AM, Muchun Song wrote:
> Ping guys. This is worth fixing.
Agree - can you respin with the suggested change?
On Wed, Oct 7, 2020 at 4:26 AM Jens Axboe <axboe@kernel.dk> wrote: > > On 9/28/20 6:50 AM, Muchun Song wrote: > > Ping guys. This is worth fixing. > > Agree - can you respin with the suggested change? OK, will do. > > -- > Jens Axboe >
We should make sure that async workqueue is canceled on exit, but on some corner case, we found that the async workqueue is not canceled on exit in the linux-5.4. So we started an in-depth investigation. Fortunately, we finally found the problem. The commit: 1c4404efcf2c ("io_uring: make sure async workqueue is canceled on exit") did not completely solve this problem. This patch series to solve this problem completely. And there's no upstream variant of this commit, so this patch series is just fix the linux-5.4.y stable branch. changelog in v2: 1. Fix missing save the current thread files 2. Fix double list add in io_queue_async_work() Muchun Song (4): io_uring: Fix missing smp_mb() in io_cancel_async_work() io_uring: Fix remove irrelevant req from the task_list io_uring: Fix missing save the current thread files io_uring: Fix double list add in io_queue_async_work() Yinyin Zhu (1): io_uring: Fix resource leaking when kill the process fs/io_uring.c | 59 +++++++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 39 insertions(+), 20 deletions(-)