| Message ID | 20200930040823.26065-4-ryan_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enable USB host for AST2600 | expand |
On Wed, Sep 30, 2020 at 12:08:23PM +0800, Ryan Chen wrote: > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
On Wed, 30 Sep 2020 at 04:08, Ryan Chen <ryan_chen@aspeedtech.com> wrote: > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Reviewed-by: Joel Stanley <joel@jms.id.au> > --- > arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > index 89be13197780..2772796e215e 100644 > --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > @@ -237,3 +237,11 @@ > &fsim0 { > status = "okay"; > }; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&uhci { > + status = "okay"; > +}; > -- > 2.17.1 >
v2: -[1/3]: Add SCSI,BLK_DEV_SD,USB_STORAGE in defconfig. -[2/3]: Fix continuation lines. v1: -The patches enable UHCI driver in AST2600 and also enable USB host in aspeed-ast2600-evb.dts. Ryan Chen (3): configs: aspeed: enable UHCI driver in defconfig usb: host: add uhci compatible support for ast2600-uhci ARM: dts: add ehci uhci enable in evb dts arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ arch/arm/configs/aspeed_g5_defconfig | 4 ++++ drivers/usb/host/uhci-platform.c | 3 ++- 3 files changed, 14 insertions(+), 1 deletion(-)
On Fri, Oct 09, 2020 at 10:49:36AM +0800, Ryan Chen wrote: > v2: > - Fix continuation lines, align with "of_device" > v1: > - Add support for AST2600 SOC UHCI driver. These all go below the --- line, as the kernel documentation asks for. > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> You have no changelog text here at all, and I can't take that, sorry. Please fix this up and resend with a proper changelog text. thanks, greg k-h
On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > v2: > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > v1: > -Enable UHCI driver in aspeed_g5_defconfig. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Why do you need this in a defconfig?
On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > v2: > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > v1: > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > Why do you need this in a defconfig? I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change. Ryan, I gave you my Reviewed-by for the last version of the patch. As you did not change the contents of this patch it is fine for you to leave my Reviewed-by on it. Cheers, Joel
On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote: > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > v2: > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > v1: > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > > > Why do you need this in a defconfig? > > I would prefer configurations that are being used to be present in the > defconfig so we can test it. I think this is a sensible change. Then it needs to be described in the changelog, otherwise we have no idea why this is happening :) thanks, greg k-h
> -----Original Message----- > From: Greg KH <greg@kroah.com> > Sent: Friday, October 9, 2020 1:47 PM > To: Joel Stanley <joel@jms.id.au> > Cc: Ryan Chen <ryan_chen@aspeedtech.com>; Andrew Jeffery > <andrew@aj.id.au>; Linux ARM <linux-arm-kernel@lists.infradead.org>; > linux-aspeed <linux-aspeed@lists.ozlabs.org>; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; linux-usb@vger.kernel.org; BMC-SW > <BMC-SW@aspeedtech.com>; Alan Stern <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig > > On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote: > > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > > v2: > > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > > v1: > > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > > > > > Why do you need this in a defconfig? > > > > I would prefer configurations that are being used to be present in the > > defconfig so we can test it. I think this is a sensible change. > > Then it needs to be described in the changelog, otherwise we have no idea > why this is happening :) > Ok, will send new version describe it.
> -----Original Message----- > From: Joel Stanley <joel@jms.id.au> > Sent: Friday, October 9, 2020 12:55 PM > To: Greg KH <greg@kroah.com> > Cc: Ryan Chen <ryan_chen@aspeedtech.com>; Andrew Jeffery > <andrew@aj.id.au>; Linux ARM <linux-arm-kernel@lists.infradead.org>; > linux-aspeed <linux-aspeed@lists.ozlabs.org>; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; linux-usb@vger.kernel.org; BMC-SW > <BMC-SW@aspeedtech.com>; Alan Stern <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig > > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > v2: > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > v1: > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > > > Why do you need this in a defconfig? > > I would prefer configurations that are being used to be present in the defconfig > so we can test it. I think this is a sensible change. > > Ryan, I gave you my Reviewed-by for the last version of the patch. As you did > not change the contents of this patch it is fine for you to leave my Reviewed-by > on it. Joel, thanks the review, so I need add Reviewed-by at each patch if someone have reviewed the previous patch, am I right?
HEllo! On 09.10.2020 5:49, Ryan Chen wrote: > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps? > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> [...] MBR, Sergei
Hello Segei, > -----Original Message----- > From: Sergei Shtylyov <sergei.shtylyov@gmail.com> > Sent: Friday, October 9, 2020 4:23 PM > To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley <joel@jms.id.au>; > Andrew Jeffery <andrew@aj.id.au>; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; > linux-usb@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; Alan Stern > <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts > > HEllo! > > On 09.10.2020 5:49, Ryan Chen wrote: > > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps? > Yes, it is enable for AST2600 EVB. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > [...] > > MBR, Sergei
Hi Ryan, On Mon, 12 Oct 2020, at 11:13, Ryan Chen wrote: > Hello Segei, > > > -----Original Message----- > > From: Sergei Shtylyov <sergei.shtylyov@gmail.com> > > Sent: Friday, October 9, 2020 4:23 PM > > To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley <joel@jms.id.au>; > > Andrew Jeffery <andrew@aj.id.au>; linux-arm-kernel@lists.infradead.org; > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; > > linux-usb@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; Alan Stern > > <stern@rowland.harvard.edu> > > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts > > > > HEllo! > > > > On 09.10.2020 5:49, Ryan Chen wrote: > > > > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > > > Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps? > > > > Yes, it is enable for AST2600 EVB. I think Sergei was suggesting you change the wording of the commit message. Andrew
> -----Original Message----- > From: Andrew Jeffery <andrew@aj.id.au> > Sent: Thursday, October 22, 2020 7:45 AM > To: Ryan Chen <ryan_chen@aspeedtech.com>; Sergei Shtylyov > <sergei.shtylyov@gmail.com>; Joel Stanley <joel@jms.id.au>; > linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; > linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; BMC-SW > <BMC-SW@aspeedtech.com>; Alan Stern <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts > > Hi Ryan, > > On Mon, 12 Oct 2020, at 11:13, Ryan Chen wrote: > > Hello Segei, > > > > > -----Original Message----- > > > From: Sergei Shtylyov <sergei.shtylyov@gmail.com> > > > Sent: Friday, October 9, 2020 4:23 PM > > > To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley > > > <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; > > > linux-arm-kernel@lists.infradead.org; > > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; > > > linux-usb@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; Alan > > > Stern <stern@rowland.harvard.edu> > > > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb > > > dts > > > > > > HEllo! > > > > > > On 09.10.2020 5:49, Ryan Chen wrote: > > > > > > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > > > > > Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps? > > > > > > > Yes, it is enable for AST2600 EVB. > > I think Sergei was suggesting you change the wording of the commit message. > Thanks, will resend the patch with modification.
diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts index 89be13197780..2772796e215e 100644 --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts @@ -237,3 +237,11 @@ &fsim0 { status = "okay"; }; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +};
Add EHCI UHCI enable build in aspeed-ast2600-evb.dts Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ 1 file changed, 8 insertions(+)