diff mbox series

btrfs: ref-verify: Fix memleak in add_extent_data_ref

Message ID 20200827074339.22950-1-dinghao.liu@zju.edu.cn (mailing list archive)
State New, archived
Headers show
Series btrfs: ref-verify: Fix memleak in add_extent_data_ref | expand

Commit Message

Dinghao Liu Aug. 27, 2020, 7:43 a.m. UTC 
When lookup_root_entry() fails, ref should be freed
just like when insert_ref_entry() fails.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
 fs/btrfs/ref-verify.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Josef Bacik Oct. 9, 2020, 2:30 p.m. UTC | #1 
On 8/27/20 3:43 AM, Dinghao Liu wrote:
> When lookup_root_entry() fails, ref should be freed
> just like when insert_ref_entry() fails.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef
diff mbox series

Patch

diff --git a/fs/btrfs/ref-verify.c b/fs/btrfs/ref-verify.c
index 7f03dbe5b609..712f5cfde404 100644
--- a/fs/btrfs/ref-verify.c
+++ b/fs/btrfs/ref-verify.c
@@ -419,6 +419,7 @@  static int add_extent_data_ref(struct btrfs_fs_info *fs_info,
 	if (!re) {
 		spin_unlock(&fs_info->ref_verify_lock);
 		btrfs_err(fs_info, "missing root in new block entry?");
+		kfree(ref);
 		return -EINVAL;
 	}
 	re->num_refs += num_refs;