| Message ID | 20201012065051.GA3458@ls3530.fritz.box (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | PATCH v2] parisc: Add MAP_UNINITIALIZED define | expand |
Am 2020-10-12 08:50, schrieb Helge Deller: > We will not allow unitialized anon mmaps, but we need this define > to prevent build errors, e.g. the debian foot package. > > Suggested-by: John David Anglin <dave.anglin@bell.net> > Signed-off-by: Helge Deller <deller@gmx.de> > > diff --git a/arch/parisc/include/uapi/asm/mman.h > b/arch/parisc/include/uapi/asm/mman.h > index 6fd8871e4081..ab78cba446ed 100644 > --- a/arch/parisc/include/uapi/asm/mman.h > +++ b/arch/parisc/include/uapi/asm/mman.h > @@ -25,6 +25,7 @@ > #define MAP_STACK 0x40000 /* give out an address that is best suited > for process/thread stacks */ > #define MAP_HUGETLB 0x80000 /* create a huge page mapping */ > #define MAP_FIXED_NOREPLACE 0x100000 /* MAP_FIXED which doesn't unmap > underlying mapping */ > +#define MAP_UNINITIALIZED 0 /* uninitialized anonymous mmap */ > > #define MS_SYNC 1 /* synchronous memory sync */ > #define MS_ASYNC 2 /* sync memory asynchronously */ > diff --git a/tools/arch/parisc/include/uapi/asm/mman.h > b/tools/arch/parisc/include/uapi/asm/mman.h > index f9fd1325f5bd..506c06a6536f 100644 > --- a/tools/arch/parisc/include/uapi/asm/mman.h > +++ b/tools/arch/parisc/include/uapi/asm/mman.h > @@ -39,6 +39,5 @@ > #define MADV_SOFT_OFFLINE 101 > /* MAP_32BIT is undefined on parisc, fix it for perf */ > #define MAP_32BIT 0 > -/* MAP_UNINITIALIZED is undefined on parisc, fix it for perf */ > #define MAP_UNINITIALIZED 0 > #endif Shouldn't the define itself be deleted here, too? Eike
On 10/12/20 10:24 AM, Rolf Eike Beer wrote: > Am 2020-10-12 08:50, schrieb Helge Deller: >> We will not allow unitialized anon mmaps, but we need this define >> to prevent build errors, e.g. the debian foot package. >> >> Suggested-by: John David Anglin <dave.anglin@bell.net> >> Signed-off-by: Helge Deller <deller@gmx.de> >> >> diff --git a/arch/parisc/include/uapi/asm/mman.h >> b/arch/parisc/include/uapi/asm/mman.h >> index 6fd8871e4081..ab78cba446ed 100644 >> --- a/arch/parisc/include/uapi/asm/mman.h >> +++ b/arch/parisc/include/uapi/asm/mman.h >> @@ -25,6 +25,7 @@ >> #define MAP_STACK 0x40000 /* give out an address that is best suited >> for process/thread stacks */ >> #define MAP_HUGETLB 0x80000 /* create a huge page mapping */ >> #define MAP_FIXED_NOREPLACE 0x100000 /* MAP_FIXED which doesn't unmap >> underlying mapping */ >> +#define MAP_UNINITIALIZED 0 /* uninitialized anonymous mmap */ >> >> #define MS_SYNC 1 /* synchronous memory sync */ >> #define MS_ASYNC 2 /* sync memory asynchronously */ >> diff --git a/tools/arch/parisc/include/uapi/asm/mman.h >> b/tools/arch/parisc/include/uapi/asm/mman.h >> index f9fd1325f5bd..506c06a6536f 100644 >> --- a/tools/arch/parisc/include/uapi/asm/mman.h >> +++ b/tools/arch/parisc/include/uapi/asm/mman.h >> @@ -39,6 +39,5 @@ >> #define MADV_SOFT_OFFLINE 101 >> /* MAP_32BIT is undefined on parisc, fix it for perf */ >> #define MAP_32BIT 0 >> -/* MAP_UNINITIALIZED is undefined on parisc, fix it for perf */ >> #define MAP_UNINITIALIZED 0 >> #endif > > Shouldn't the define itself be deleted here, too? No, because it doesn't include arch/parisc/include/uapi/asm/mman.h Helge
diff --git a/arch/parisc/include/uapi/asm/mman.h b/arch/parisc/include/uapi/asm/mman.h index 6fd8871e4081..ab78cba446ed 100644 --- a/arch/parisc/include/uapi/asm/mman.h +++ b/arch/parisc/include/uapi/asm/mman.h @@ -25,6 +25,7 @@ #define MAP_STACK 0x40000 /* give out an address that is best suited for process/thread stacks */ #define MAP_HUGETLB 0x80000 /* create a huge page mapping */ #define MAP_FIXED_NOREPLACE 0x100000 /* MAP_FIXED which doesn't unmap underlying mapping */ +#define MAP_UNINITIALIZED 0 /* uninitialized anonymous mmap */ #define MS_SYNC 1 /* synchronous memory sync */ #define MS_ASYNC 2 /* sync memory asynchronously */ diff --git a/tools/arch/parisc/include/uapi/asm/mman.h b/tools/arch/parisc/include/uapi/asm/mman.h index f9fd1325f5bd..506c06a6536f 100644 --- a/tools/arch/parisc/include/uapi/asm/mman.h +++ b/tools/arch/parisc/include/uapi/asm/mman.h @@ -39,6 +39,5 @@ #define MADV_SOFT_OFFLINE 101 /* MAP_32BIT is undefined on parisc, fix it for perf */ #define MAP_32BIT 0 -/* MAP_UNINITIALIZED is undefined on parisc, fix it for perf */ #define MAP_UNINITIALIZED 0 #endif
We will not allow unitialized anon mmaps, but we need this define to prevent build errors, e.g. the debian foot package. Suggested-by: John David Anglin <dave.anglin@bell.net> Signed-off-by: Helge Deller <deller@gmx.de>