Message ID | 20201013065313.7349-1-laurent@vivier.eu (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote: > > The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int= > o staging (2020-10-12 11:29:42 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request > > for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c: > > meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200) > > ---------------------------------------------------------------- > Trivial Patches Pull request 20201013 > > ---------------------------------------------------------------- Compile failure on ppc64be: ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’: ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array bounds [-Werror=array-bounds] return s->dcdc[addr - MENELAUS_VCORE_CTRL1]; ^ cc1: all warnings being treated as errors thanks -- PMM
Le 13/10/2020 à 13:06, Peter Maydell a écrit : > On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote: >> >> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int= >> o staging (2020-10-12 11:29:42 +0100) >> >> are available in the Git repository at: >> >> git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request >> >> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c: >> >> meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200) >> >> ---------------------------------------------------------------- >> Trivial Patches Pull request 20201013 >> >> ---------------------------------------------------------------- > > Compile failure on ppc64be: > > ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’: > ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array > bounds [-Werror=array-bounds] > return s->dcdc[addr - MENELAUS_VCORE_CTRL1]; > ^ > cc1: all warnings being treated as errors Thank you. I'm removing the following patch patch from the pull request: hw/rtc/twl92230: Silence warnings about missing fallthrough statements Thanks, Laurent
On 13/10/2020 13.06, Peter Maydell wrote: > On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote: >> >> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int= >> o staging (2020-10-12 11:29:42 +0100) >> >> are available in the Git repository at: >> >> git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request >> >> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c: >> >> meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200) >> >> ---------------------------------------------------------------- >> Trivial Patches Pull request 20201013 >> >> ---------------------------------------------------------------- > > Compile failure on ppc64be: > > ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’: > ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array > bounds [-Werror=array-bounds] > return s->dcdc[addr - MENELAUS_VCORE_CTRL1]; Uh, oh, mea culpa, copy-n-paste error... that should have been MENELAUS_DCDC_CTRL1 instead. Laurent, could you fix it up, or shall I send a v2 of the patch? Thomas
Le 13/10/2020 à 13:34, Thomas Huth a écrit : > On 13/10/2020 13.06, Peter Maydell wrote: >> On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote: >>> >>> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54: >>> >>> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int= >>> o staging (2020-10-12 11:29:42 +0100) >>> >>> are available in the Git repository at: >>> >>> git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request >>> >>> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c: >>> >>> meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200) >>> >>> ---------------------------------------------------------------- >>> Trivial Patches Pull request 20201013 >>> >>> ---------------------------------------------------------------- >> >> Compile failure on ppc64be: >> >> ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’: >> ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array >> bounds [-Werror=array-bounds] >> return s->dcdc[addr - MENELAUS_VCORE_CTRL1]; > > Uh, oh, mea culpa, copy-n-paste error... that should have been > MENELAUS_DCDC_CTRL1 instead. > Laurent, could you fix it up, or shall I send a v2 of the patch? I prefere a v2, I don't like to play with patches in a pull request. Thanks, Laurent
On 13/10/2020 13.40, Laurent Vivier wrote: > Le 13/10/2020 à 13:34, Thomas Huth a écrit : >> On 13/10/2020 13.06, Peter Maydell wrote: >>> On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote: >>>> >>>> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54: >>>> >>>> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int= >>>> o staging (2020-10-12 11:29:42 +0100) >>>> >>>> are available in the Git repository at: >>>> >>>> git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request >>>> >>>> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c: >>>> >>>> meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200) >>>> >>>> ---------------------------------------------------------------- >>>> Trivial Patches Pull request 20201013 >>>> >>>> ---------------------------------------------------------------- >>> >>> Compile failure on ppc64be: >>> >>> ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’: >>> ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array >>> bounds [-Werror=array-bounds] >>> return s->dcdc[addr - MENELAUS_VCORE_CTRL1]; >> >> Uh, oh, mea culpa, copy-n-paste error... that should have been >> MENELAUS_DCDC_CTRL1 instead. >> Laurent, could you fix it up, or shall I send a v2 of the patch? > > I prefere a v2, I don't like to play with patches in a pull request. Sure, I'll send a v2 when I've got some spare time (i.e. for a future pull request, not for this one). Thomas