diff mbox series

scsi: bfa: fix error return in bfad_pci_init()

Message ID 20200925062423.161504-1-jingxiangfeng@huawei.com (mailing list archive)
State Accepted
Headers show
Series scsi: bfa: fix error return in bfad_pci_init() | expand

Commit Message

Jing Xiangfeng Sept. 25, 2020, 6:24 a.m. UTC
Fix to return error code -ENODEV from the error handling case instead
of 0.

Fixes: 11ea3824140c ("scsi: bfa: fix calls to dma_set_mask_and_coherent()")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 drivers/scsi/bfa/bfad.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin K. Petersen Oct. 8, 2020, 2:45 a.m. UTC | #1
Jing,

> Fix to return error code -ENODEV from the error handling case instead
> of 0.

Applied to 5.10/scsi-staging, thanks!
Martin K. Petersen Oct. 13, 2020, 10:42 p.m. UTC | #2
On Fri, 25 Sep 2020 14:24:23 +0800, Jing Xiangfeng wrote:

> Fix to return error code -ENODEV from the error handling case instead
> of 0.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: bfa: Fix error return in bfad_pci_init()
      https://git.kernel.org/mkp/scsi/c/f0f6c3a4fcb8
diff mbox series

Patch

diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c
index bc5d84f87d8f..440ef32be048 100644
--- a/drivers/scsi/bfa/bfad.c
+++ b/drivers/scsi/bfa/bfad.c
@@ -749,6 +749,7 @@  bfad_pci_init(struct pci_dev *pdev, struct bfad_s *bfad)
 
 	if (bfad->pci_bar0_kva == NULL) {
 		printk(KERN_ERR "Fail to map bar0\n");
+		rc = -ENODEV;
 		goto out_release_region;
 	}