| Message ID | 20201015045447.1440-1-pawell@cadence.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cdd3013dcc5cf6b03150caac0b96212ab221cf7a |
| Headers | show |
| Series | [v4] usb: cdns3: Rids of duplicate error message | expand |
On 15/10/2020 07:54, Pawel Laszczak wrote: > On failure, the platform_get_irq_byname prints an error message, > so patch removes error message related to this function from > core.c file. > > A change was suggested during reviewing CDNSP driver by Chunfeng Yun. > > Signed-off-by: Pawel Laszczak <pawell@cadence.com> > Acked-by: Peter Chen <peter.chen@nxp.com> Acked-by: Roger Quadros <rogerq@ti.com> > --- > Changelog: > v4 > - fixed typo. > - "Acked-by" tag has been added. > v3 > - changed error condition checking for dev_irq. > v2 > - simplified code as sugested by Roger Quadros. > > drivers/usb/cdns3/core.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c > index a0f73d4711ae..f2dedce3a40e 100644 > --- a/drivers/usb/cdns3/core.c > +++ b/drivers/usb/cdns3/core.c > @@ -466,11 +466,8 @@ static int cdns3_probe(struct platform_device *pdev) > cdns->xhci_res[1] = *res; > > cdns->dev_irq = platform_get_irq_byname(pdev, "peripheral"); > - if (cdns->dev_irq == -EPROBE_DEFER) > - return cdns->dev_irq; > - > if (cdns->dev_irq < 0) > - dev_err(dev, "couldn't get peripheral irq\n"); > + return cdns->dev_irq; > > regs = devm_platform_ioremap_resource_byname(pdev, "dev"); > if (IS_ERR(regs)) > @@ -478,14 +475,9 @@ static int cdns3_probe(struct platform_device *pdev) > cdns->dev_regs = regs; > > cdns->otg_irq = platform_get_irq_byname(pdev, "otg"); > - if (cdns->otg_irq == -EPROBE_DEFER) > + if (cdns->otg_irq < 0) > return cdns->otg_irq; > > - if (cdns->otg_irq < 0) { > - dev_err(dev, "couldn't get otg irq\n"); > - return cdns->otg_irq; > - } > - > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "otg"); > if (!res) { > dev_err(dev, "couldn't get otg resource\n"); >
diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index a0f73d4711ae..f2dedce3a40e 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -466,11 +466,8 @@ static int cdns3_probe(struct platform_device *pdev) cdns->xhci_res[1] = *res; cdns->dev_irq = platform_get_irq_byname(pdev, "peripheral"); - if (cdns->dev_irq == -EPROBE_DEFER) - return cdns->dev_irq; - if (cdns->dev_irq < 0) - dev_err(dev, "couldn't get peripheral irq\n"); + return cdns->dev_irq; regs = devm_platform_ioremap_resource_byname(pdev, "dev"); if (IS_ERR(regs)) @@ -478,14 +475,9 @@ static int cdns3_probe(struct platform_device *pdev) cdns->dev_regs = regs; cdns->otg_irq = platform_get_irq_byname(pdev, "otg"); - if (cdns->otg_irq == -EPROBE_DEFER) + if (cdns->otg_irq < 0) return cdns->otg_irq; - if (cdns->otg_irq < 0) { - dev_err(dev, "couldn't get otg irq\n"); - return cdns->otg_irq; - } - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "otg"); if (!res) { dev_err(dev, "couldn't get otg resource\n");