[v1,4/6] spi: cadence-quadspi: Add QSPI support for Intel LGM SoC

Commit Message

Ramuthevar,Vadivel MuruganX Oct. 16, 2020, 9:31 a.m. UTC

From: Ramuthevar Vadivel Murugan <[e-mail]>

Add QSPI controller support for Intel LGM SoC.

Signed-off-by: Ramuthevar Vadivel Murugan <[e-mail]>
---
 drivers/spi/Kconfig               | 2 +-
 drivers/spi/spi-cadence-quadspi.c | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Mark Brown Oct. 16, 2020, 4:33 p.m. UTC | #1

On Fri, Oct 16, 2020 at 05:31:36PM +0800, Ramuthevar,Vadivel MuruganX wrote:

> +	depends on OF && (ARM || ARM64 || X86 || COMPILE_TEST)

> +	{
> +		.compatible = "intel,lgm-qspi",
> +	},

This is an x86 SoC (or SoC series) - is it really going to use DT for
the firmware interfaces?  It's not specifically a problem, just
surprising to see something other than ACPI.  Or is the intention to use
PRP0001?  There's a new comaptible here which wasn't really the use case
for PRP0001.  Like I say not really a problem, just curious.

Ramuthevar,Vadivel MuruganX Oct. 19, 2020, 6:26 a.m. UTC | #2

Hi Mark,

On 17/10/2020 12:33 am, Mark Brown wrote:
> On Fri, Oct 16, 2020 at 05:31:36PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> 
>> +	depends on OF && (ARM || ARM64 || X86 || COMPILE_TEST)
> 
>> +	{
>> +		.compatible = "intel,lgm-qspi",
>> +	},
> 
> This is an x86 SoC (or SoC series) - is it really going to use DT for
> the firmware interfaces? 
Thank you for the review comments...
Intel LGM SoC does uses DT based firmware blob.
  It's not specifically a problem, just
> surprising to see something other than ACPI.  Or is the intention to use
> PRP0001? 
Yes, You're right most of them uses ACPI based, but LGM SoC doesn't.

Regards
Vadivel
  There's a new comaptible here which wasn't really the use case
> for PRP0001.  Like I say not really a problem, just curious.
>

Patch

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index d2c976e55b8b..926da61eee5a 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -203,7 +203,7 @@  config SPI_CADENCE
 
 config SPI_CADENCE_QUADSPI
 	tristate "Cadence Quad SPI controller"
-	depends on OF && (ARM || ARM64 || COMPILE_TEST)
+	depends on OF && (ARM || ARM64 || X86 || COMPILE_TEST)
 	help
 	  Enable support for the Cadence Quad SPI Flash controller.
 
diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 40938cf3806d..d7b10c46fa70 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1401,6 +1401,9 @@  static const struct of_device_id cqspi_dt_ids[] = {
 		.compatible = "ti,am654-ospi",
 		.data = &am654_ospi,
 	},
+	{
+		.compatible = "intel,lgm-qspi",
+	},
 	{ /* end of table */ }
 };