mbox series

[v11,0/7] Finish converting git bisect to C part 2 subset 2

Message ID 20201015133838.85524-1-mirucam@gmail.com (mailing list archive)
Headers show
Series Finish converting git bisect to C part 2 subset 2 | expand

Message

Miriam R. Oct. 15, 2020, 1:38 p.m. UTC
These patches correspond to a second part of patch series 
of Outreachy project "Finish converting `git bisect` from shell to C" 
started by Pranit Bauva and Tanushree Tumane
(https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
continued by me.

This patch series version is composed by the last seven patches of part2
set. 

These patch series emails were generated from:
https://gitlab.com/mirucam/git/commits/git-bisect-work-part2-v11-subset2.

I would like to thank Johannes Schindelin for reviewing this patch series.


General information
-------------------

* Rebased on d4a392452e (Git 2.29-rc1, 2020-10-08).

Specific changes
----------------

[4/7]bisect--helper: reimplement `bisect_state` & `bisect_head` shell
    functions in C
    
* Add `oid_array_clear()` calls before return BISECT_FAILED;
    
---
Pranit Bauva (7):
  bisect--helper: finish porting `bisect_start()` to C
  bisect--helper: retire `--bisect-clean-state` subcommand
  bisect--helper: retire `--next-all` subcommand
  bisect--helper: reimplement `bisect_state` & `bisect_head` shell
    functions in C
  bisect--helper: retire `--check-expected-revs` subcommand
  bisect--helper: retire `--write-terms` subcommand
  bisect--helper: retire `--bisect-autostart` subcommand

 builtin/bisect--helper.c | 187 +++++++++++++++++++++++----------------
 git-bisect.sh            |  81 ++---------------
 2 files changed, 117 insertions(+), 151 deletions(-)

Comments

Johannes Schindelin Oct. 15, 2020, 8:41 p.m. UTC | #1
Hi Miriam,

On Thu, 15 Oct 2020, Miriam Rubio wrote:

> These patches correspond to a second part of patch series
> of Outreachy project "Finish converting `git bisect` from shell to C"
> started by Pranit Bauva and Tanushree Tumane
> (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
> continued by me.
>
> This patch series version is composed by the last seven patches of part2
> set.
>
> These patch series emails were generated from:
> https://gitlab.com/mirucam/git/commits/git-bisect-work-part2-v11-subset2.
>
> I would like to thank Johannes Schindelin for reviewing this patch series.

Thank you so much for driving this forward.

This entire series is Reviewed-by: me.

Thanks!
Dscho
Junio C Hamano Oct. 16, 2020, 7:26 p.m. UTC | #2
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi Miriam,
>
> On Thu, 15 Oct 2020, Miriam Rubio wrote:
>
>> These patches correspond to a second part of patch series
>> of Outreachy project "Finish converting `git bisect` from shell to C"
>> started by Pranit Bauva and Tanushree Tumane
>> (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
>> continued by me.
>>
>> This patch series version is composed by the last seven patches of part2
>> set.
>>
>> These patch series emails were generated from:
>> https://gitlab.com/mirucam/git/commits/git-bisect-work-part2-v11-subset2.
>>
>> I would like to thank Johannes Schindelin for reviewing this patch series.
>
> Thank you so much for driving this forward.
>
> This entire series is Reviewed-by: me.

Will, queue; thanks, both.