| Message ID | 20201018151726.GA219649@ubuntu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] iio: proximity: vl53l0x-i2c add i2c_device_id | expand |
On Sun, Oct 18, 2020 at 6:53 PM Vaishnav M A <vaishnav@beagleboard.org> wrote: > > Add i2c_device_id table for the vl53l0x-i2c driver, > helps in device instantiation using i2c_new_client_device > or from userspace in cases where device-tree based description > is not possible now (Example: device on a gbphy i2c adapter > created by greybus) Same comments as per v1.
On Mon, Oct 19, 2020 at 12:00 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sun, Oct 18, 2020 at 6:53 PM Vaishnav M A <vaishnav@beagleboard.org> wrote: > > > > Add i2c_device_id table for the vl53l0x-i2c driver, > > helps in device instantiation using i2c_new_client_device > > or from userspace in cases where device-tree based description > > is not possible now (Example: device on a gbphy i2c adapter > > created by greybus) > > Same comments as per v1. > > -- > With Best Regards, > Andy Shevchenko Thank you Andy for your review, I have updated v4 patch with your suggestions : https://lore.kernel.org/patchwork/patch/1322218/ Thanks, Vaishnav
diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c index 5fbda9475ba9..7c29d4cae24a 100644 --- a/drivers/iio/proximity/vl53l0x-i2c.c +++ b/drivers/iio/proximity/vl53l0x-i2c.c @@ -143,6 +143,12 @@ static int vl53l0x_probe(struct i2c_client *client) return devm_iio_device_register(&client->dev, indio_dev); } +static const struct i2c_device_id vl53l0x_id[] = { + { "vl53l0x", 0}, + { } +}; +MODULE_DEVICE_TABLE(i2c, vl53l0x_id); + static const struct of_device_id st_vl53l0x_dt_match[] = { { .compatible = "st,vl53l0x", }, { } @@ -155,6 +161,7 @@ static struct i2c_driver vl53l0x_driver = { .of_match_table = st_vl53l0x_dt_match, }, .probe_new = vl53l0x_probe, + .id_table = vl53l0x_id, }; module_i2c_driver(vl53l0x_driver);
Add i2c_device_id table for the vl53l0x-i2c driver, helps in device instantiation using i2c_new_client_device or from userspace in cases where device-tree based description is not possible now (Example: device on a gbphy i2c adapter created by greybus) Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org> --- v3: -modify commit message for readability as suggested by Jonathan Cameron v2: -fix commit message drivers/iio/proximity/vl53l0x-i2c.c | 7 +++++++ 1 file changed, 7 insertions(+)