| Message ID | 20201018194912.2716372-1-gitster@pobox.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Claryfing the meaning of the sign-off | expand |
Hi Junio, On Sun, Oct 18, 2020 at 12:49:09PM -0700, Junio C Hamano wrote: > So here is to tie the loose ends, based on inputs to the first > round. All of this looks very good to me, and I really appreciate 1/3, since it made reviewing 2/3 much easier (the combination of seeing more-or-less the same diff twice combined with the re-wrapping made it tricky to read, at least for me). Reviewed-by: Taylor Blau <me@ttaylorr.com> Thanks, Taylor
So here is to tie the loose ends, based on inputs to the first round. * [1/3] is new; this is a preparatory clean-up to dedup two very similar paragraphs in the existing documentation, thanks to the idea by Philippe Blain. * [2/3] is text taken from Bradley's patch to update the manpages; thanks to the preparatory clean-up, we no longer need to duplicate the new text. Grammofix pointed out by Ted Ts'o has also been applied. * [3/3] clarifies what sign-off means to _this_ project. This step hasn't changed from what has been queued in 'seen'. For those who missed the original, it appears at lore.kernel.org/git/20201015215933.96425-1-bkuhn@sfconservancy.org Bradley M. Kuhn (1): Documentation: clarify and expand description of --signoff Junio C Hamano (2): doc: preparatory clean-up of description on the sign-off option SubmittingPatches: clarify DCO is our --signoff rule Documentation/SubmittingPatches | 25 ++++++++++++++----------- Documentation/git-commit.txt | 10 ++-------- Documentation/merge-options.txt | 11 +---------- Documentation/signoff-option.txt | 18 ++++++++++++++++++ 4 files changed, 35 insertions(+), 29 deletions(-) create mode 100644 Documentation/signoff-option.txt