| Message ID | 1603087462-37505-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dd29bd41d4c6e1fc837a28f9a68bf344500dcced |
| Headers | show |
| Series | drm/msm: Remove redundant null check | expand |
On Mon, Oct 19, 2020 at 02:04:22PM +0800, Tian Tao wrote: > clk_prepare_enable() and clk_disable_unprepare() will check > NULL clock parameter, so It is not necessary to add additional checks. Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > drivers/gpu/drm/msm/msm_gpu.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c > index 57ddc94..25bc654 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.c > +++ b/drivers/gpu/drm/msm/msm_gpu.c > @@ -175,15 +175,12 @@ static int disable_clk(struct msm_gpu *gpu) > > static int enable_axi(struct msm_gpu *gpu) > { > - if (gpu->ebi1_clk) > - clk_prepare_enable(gpu->ebi1_clk); > - return 0; > + return clk_prepare_enable(gpu->ebi1_clk); > } > > static int disable_axi(struct msm_gpu *gpu) > { > - if (gpu->ebi1_clk) > - clk_disable_unprepare(gpu->ebi1_clk); > + clk_disable_unprepare(gpu->ebi1_clk); > return 0; > } > > -- > 2.7.4 > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Mon, 19 Oct 2020 14:04:22 +0800 you wrote: > clk_prepare_enable() and clk_disable_unprepare() will check > NULL clock parameter, so It is not necessary to add additional checks. > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > drivers/gpu/drm/msm/msm_gpu.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Here is the summary with links: - drm/msm: Remove redundant null check https://git.kernel.org/qcom/c/dd29bd41d4c6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 57ddc94..25bc654 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -175,15 +175,12 @@ static int disable_clk(struct msm_gpu *gpu) static int enable_axi(struct msm_gpu *gpu) { - if (gpu->ebi1_clk) - clk_prepare_enable(gpu->ebi1_clk); - return 0; + return clk_prepare_enable(gpu->ebi1_clk); } static int disable_axi(struct msm_gpu *gpu) { - if (gpu->ebi1_clk) - clk_disable_unprepare(gpu->ebi1_clk); + clk_disable_unprepare(gpu->ebi1_clk); return 0; }
clk_prepare_enable() and clk_disable_unprepare() will check NULL clock parameter, so It is not necessary to add additional checks. Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/gpu/drm/msm/msm_gpu.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)