| Message ID | 20200911122220.13698-1-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ARM: dts: exynos: Remove 'opp-shared' from Exynos3 bus OPP-tables | expand |
On Fri, Sep 11, 2020 at 02:22:20PM +0200, Marek Szyprowski wrote: > Commits 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the > values correct for Exynos5422 Odroids") and 9ff416cf45a0 ("ARM: dts: > exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family") > revealed that 'opp-shared' property for the Exynos bus OPPs was used > incorrectly, what had the side-effect of disabling frequency scaling for > the second and latter buses sharing given OPP-table. > > Fix this by removing bogus 'opp-shared' properties from Exynos3 bus > OPP-tables. This restores frequency scaling for the following busses: > RightBus, LCD0, FSYS and MFC. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 5 ----- > 1 file changed, 5 deletions(-) Hi Marek, Any news on these two patches? Shall I still wait? Best regards, Krzysztof
Hi Krzysztof, On 26.10.2020 19:35, Krzysztof Kozlowski wrote: > On Fri, Sep 11, 2020 at 02:22:20PM +0200, Marek Szyprowski wrote: >> Commits 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the >> values correct for Exynos5422 Odroids") and 9ff416cf45a0 ("ARM: dts: >> exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family") >> revealed that 'opp-shared' property for the Exynos bus OPPs was used >> incorrectly, what had the side-effect of disabling frequency scaling for >> the second and latter buses sharing given OPP-table. >> >> Fix this by removing bogus 'opp-shared' properties from Exynos3 bus >> OPP-tables. This restores frequency scaling for the following busses: >> RightBus, LCD0, FSYS and MFC. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 5 ----- >> 1 file changed, 5 deletions(-) > Hi Marek, > > Any news on these two patches? Shall I still wait? I would apply it to give the testing in -next. I got the information that the crash was not reproduced, thus probably not related to this patch. Best regards
On Fri, Sep 11, 2020 at 02:22:20PM +0200, Marek Szyprowski wrote: > Commits 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the > values correct for Exynos5422 Odroids") and 9ff416cf45a0 ("ARM: dts: > exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family") > revealed that 'opp-shared' property for the Exynos bus OPPs was used > incorrectly, what had the side-effect of disabling frequency scaling for > the second and latter buses sharing given OPP-table. > > Fix this by removing bogus 'opp-shared' properties from Exynos3 bus > OPP-tables. This restores frequency scaling for the following busses: > RightBus, LCD0, FSYS and MFC. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 5 ----- Thanks, applied. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index a1e93fb7f694..75ed82600ec8 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -775,7 +775,6 @@ bus_dmc_opp_table: opp_table1 { compatible = "operating-points-v2"; - opp-shared; opp-50000000 { opp-hz = /bits/ 64 <50000000>; @@ -865,7 +864,6 @@ bus_leftbus_opp_table: opp_table2 { compatible = "operating-points-v2"; - opp-shared; opp-50000000 { opp-hz = /bits/ 64 <50000000>; @@ -891,7 +889,6 @@ bus_mcuisp_opp_table: opp_table3 { compatible = "operating-points-v2"; - opp-shared; opp-50000000 { opp-hz = /bits/ 64 <50000000>; @@ -912,7 +909,6 @@ bus_isp_opp_table: opp_table4 { compatible = "operating-points-v2"; - opp-shared; opp-50000000 { opp-hz = /bits/ 64 <50000000>; @@ -933,7 +929,6 @@ bus_peril_opp_table: opp_table5 { compatible = "operating-points-v2"; - opp-shared; opp-50000000 { opp-hz = /bits/ 64 <50000000>;
Commits 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the values correct for Exynos5422 Odroids") and 9ff416cf45a0 ("ARM: dts: exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family") revealed that 'opp-shared' property for the Exynos bus OPPs was used incorrectly, what had the side-effect of disabling frequency scaling for the second and latter buses sharing given OPP-table. Fix this by removing bogus 'opp-shared' properties from Exynos3 bus OPP-tables. This restores frequency scaling for the following busses: RightBus, LCD0, FSYS and MFC. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos3250.dtsi | 5 ----- 1 file changed, 5 deletions(-)