| Message ID | 79cc61f56adf7769521d2e2ba4c27c1a3bbc1d76.1603740773.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 33226af42b8fbdc7551a56753123385a5ee079fa |
| Headers | show |
| Series | Update fsmonitor perf suite to support integration comparisons | expand |
"Nipunn Koorapati via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Nipunn Koorapati <nipunn@dropbox.com> > > Previously - it would silently run the perf suite w/o using > fsmonitor - fsmonitor errors are not hard failures. > Now it errors loudly. > > GIT_PERF_7519_FSMONITOR="$HOME/rs-git-fsmonitorr" > ./p7519-fsmonitor.sh -i -v > > fatal: cannot run /home/nipunn/rs-git-fsmonitorr: > No such file or directory > not ok 2 - setup for fsmonitor > > Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com> > --- > t/perf/p7519-fsmonitor.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh > index 4030f569cf..88b3717e2a 100755 > --- a/t/perf/p7519-fsmonitor.sh > +++ b/t/perf/p7519-fsmonitor.sh > @@ -126,7 +126,9 @@ test_expect_success "setup for fsmonitor" ' > fi && > > git config core.fsmonitor "$INTEGRATION_SCRIPT" && > - git update-index --fsmonitor && > + git update-index --fsmonitor 2>error && > + cat error && > + [ ! -s error ] && # ensure no silent error I usually do not review or write t/perf/, but is test_must_be_empty available to you at this point? > git status # Warm caches > '
> I usually do not review or write t/perf/, but is test_must_be_empty > available to you at this point? Everything in test-lib should be available - so yes! I can try it out and switch to it in the next roll of this patch series. I did not realize this helper was available. Thank you. --Nipunn
diff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh index 4030f569cf..88b3717e2a 100755 --- a/t/perf/p7519-fsmonitor.sh +++ b/t/perf/p7519-fsmonitor.sh @@ -126,7 +126,9 @@ test_expect_success "setup for fsmonitor" ' fi && git config core.fsmonitor "$INTEGRATION_SCRIPT" && - git update-index --fsmonitor && + git update-index --fsmonitor 2>error && + cat error && + [ ! -s error ] && # ensure no silent error git status # Warm caches '