| Message ID | 20201015045529.2022-1-pawell@cadence.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | defe40af1a7143a0538d7c3e87224459eea0a877 |
| Headers | show |
| Series | [v3] usb: cdns3: Variable 'length' set but not used | expand |
Hi Peter, A gentle ping. I assume that you should add this and the rest overdue cdsn3 patches as first to you ci-for-usb-next branch. Am I right? Pawel >Patch removes not used variable 'length' from >cdns3_wa2_descmiss_copy_data function. > >Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case") >Signed-off-by: Pawel Laszczak <pawell@cadence.com> >Acked-by: Roger Quadros <rogerq@ti.com> >--- >Changelog: >v3 >- added "Acked-by" tag. >v2 >- added "Fixes" tag. > > drivers/usb/cdns3/gadget.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c >index 6e7b70a2e352..692acf7b9b14 100644 >--- a/drivers/usb/cdns3/gadget.c >+++ b/drivers/usb/cdns3/gadget.c >@@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep, > > while (!list_empty(&priv_ep->wa2_descmiss_req_list)) { > int chunk_end; >- int length; > > descmiss_priv_req = > cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list); >@@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep, > break; > > chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH; >- length = request->actual + descmiss_req->actual; > request->status = descmiss_req->status; > __cdns3_descmiss_copy_data(request, descmiss_req); > list_del_init(&descmiss_priv_req->list); >-- >2.17.1
> > A gentle ping. > > I assume that you should add this and the rest overdue cdsn3 patches as first > to you ci-for-usb-next branch. > Am I right? > Hi Pawel, I queued them locally, and I waited for v5.10-rc1 which was out yesterday, then I will apply them, and add cdns3 patches to my kernel.org branch. Will update you these two days. Peter
> > > > A gentle ping. > > > > I assume that you should add this and the rest overdue cdsn3 patches > > as first to you ci-for-usb-next branch. > > Am I right? > > > > Hi Pawel, > > I queued them locally, and I waited for v5.10-rc1 which was out yesterday, then > I will apply them, and add cdns3 patches to my kernel.org branch. Will update > you these two days. > > Peter Hi Pawel, The cdns3 -next patches pushed to: for-usb-next; cdns3 -fixes patches pushed to: for-usb-fixes. The git is: git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git Currently, I only pushed three of your patches, would you please review my patches, thanks. Peter
Peter, It looks like you missed the " [PATCH v3] usb: cdns3: Variable 'length' set but not used" It's quite important because compiler complains for this when I use W=1. Thanks, Pawel >> > >> > A gentle ping. >> > >> > I assume that you should add this and the rest overdue cdsn3 patches >> > as first to you ci-for-usb-next branch. >> > Am I right? >> > >> >> Hi Pawel, >> >> I queued them locally, and I waited for v5.10-rc1 which was out yesterday, then >> I will apply them, and add cdns3 patches to my kernel.org branch. Will update >> you these two days. >> >> Peter > >Hi Pawel, > >The cdns3 -next patches pushed to: for-usb-next; cdns3 -fixes patches pushed to: for-usb-fixes. >The git is: git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git > >Currently, I only pushed three of your patches, would you please review my patches, thanks. > >Peter
> Peter, > > It looks like you missed the " [PATCH v3] usb: cdns3: Variable 'length' set but > not used" > > It's quite important because compiler complains for this when I use W=1. > Pawel, it is the bug-fix, and located at branch: for-usb-fixes. > Thanks, > Pawel > > >> > > >> > A gentle ping. > >> > > >> > I assume that you should add this and the rest overdue cdsn3 > >> > patches as first to you ci-for-usb-next branch. > >> > Am I right? > >> > > >> > >> Hi Pawel, > >> > >> I queued them locally, and I waited for v5.10-rc1 which was out > >> yesterday, then I will apply them, and add cdns3 patches to my > >> kernel.org branch. Will update you these two days. > >> > >> Peter > > > >Hi Pawel, > > > >The cdns3 -next patches pushed to: for-usb-next; cdns3 -fixes patches pushed > to: for-usb-fixes. > >The git is: > >git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git > > > >Currently, I only pushed three of your patches, would you please review my > patches, thanks. > > > >Peter
> >> Peter, >> >> It looks like you missed the " [PATCH v3] usb: cdns3: Variable 'length' set but >> not used" >> >> It's quite important because compiler complains for this when I use W=1. >> > >Pawel, it is the bug-fix, and located at branch: for-usb-fixes. But I can't see it in this branch: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git/log/?h=for-usb-fixes&qt=grep&q=cdns3 I can see there only: usb: cdns3: Rids of duplicate error message. > >> Thanks, >> Pawel >> >> >> > >> >> > A gentle ping. >> >> > >> >> > I assume that you should add this and the rest overdue cdsn3 >> >> > patches as first to you ci-for-usb-next branch. >> >> > Am I right? >> >> > >> >> >> >> Hi Pawel, >> >> >> >> I queued them locally, and I waited for v5.10-rc1 which was out >> >> yesterday, then I will apply them, and add cdns3 patches to my >> >> kernel.org branch. Will update you these two days. >> >> >> >> Peter >> > >> >Hi Pawel, >> > >> >The cdns3 -next patches pushed to: for-usb-next; cdns3 -fixes patches pushed >> to: for-usb-fixes. >> >The git is: >> >git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git >> > >> >Currently, I only pushed three of your patches, would you please review my >> patches, thanks. >> > >> >Peter
> > > > >> Peter, > >> > >> It looks like you missed the " [PATCH v3] usb: cdns3: Variable > >> 'length' set but not used" > >> > >> It's quite important because compiler complains for this when I use W=1. > >> > > > >Pawel, it is the bug-fix, and located at branch: for-usb-fixes. > > But I can't see it in this branch: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kern > el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fpeter.chen%2Fusb.git%2Flo > g%2F%3Fh%3Dfor-usb-fixes%26qt%3Dgrep%26q%3Dcdns3&data=04%7C > 01%7Cpeter.chen%40nxp.com%7Cc49c80ded3ec4bae70aa08d87b120467%7C > 686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637394664604902329%7 > CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBT > iI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=jtcT0U8ZptlBSwST00%2B > bMtCQDZDr%2B3PNMm69RrZWgDs%3D&reserved=0 > > I can see there only: usb: cdns3: Rids of duplicate error message. > Thanks for notifying it, I have updated it. Peter > > > >> Thanks, > >> Pawel > >> > >> >> > > >> >> > A gentle ping. > >> >> > > >> >> > I assume that you should add this and the rest overdue cdsn3 > >> >> > patches as first to you ci-for-usb-next branch. > >> >> > Am I right? > >> >> > > >> >> > >> >> Hi Pawel, > >> >> > >> >> I queued them locally, and I waited for v5.10-rc1 which was out > >> >> yesterday, then I will apply them, and add cdns3 patches to my > >> >> kernel.org branch. Will update you these two days. > >> >> > >> >> Peter > >> > > >> >Hi Pawel, > >> > > >> >The cdns3 -next patches pushed to: for-usb-next; cdns3 -fixes > >> >patches pushed > >> to: for-usb-fixes. > >> >The git is: > >> >git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git > >> > > >> >Currently, I only pushed three of your patches, would you please > >> >review my > >> patches, thanks. > >> > > >> >Peter
diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c index 6e7b70a2e352..692acf7b9b14 100644 --- a/drivers/usb/cdns3/gadget.c +++ b/drivers/usb/cdns3/gadget.c @@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep, while (!list_empty(&priv_ep->wa2_descmiss_req_list)) { int chunk_end; - int length; descmiss_priv_req = cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list); @@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep, break; chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH; - length = request->actual + descmiss_req->actual; request->status = descmiss_req->status; __cdns3_descmiss_copy_data(request, descmiss_req); list_del_init(&descmiss_priv_req->list);
Patch removes not used variable 'length' from cdns3_wa2_descmiss_copy_data function. Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case") Signed-off-by: Pawel Laszczak <pawell@cadence.com> Acked-by: Roger Quadros <rogerq@ti.com> --- Changelog: v3 - added "Acked-by" tag. v2 - added "Fixes" tag. drivers/usb/cdns3/gadget.c | 2 -- 1 file changed, 2 deletions(-)