| Message ID | cb5bb49a33ff54fef41e719ee9d301a6a73c5f9c.1603788512.git.yepeilin.cs@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Preparation work for using font_desc in vc_data | expand |
On Tue, Oct 27, 2020 at 12:31:08PM -0400, Peilin Ye wrote: > Remove 6 unused extern variables to reduce confusion. It is worth > mentioning that lib/fonts/font_8x8.c and lib/fonts/font_8x16.c also > declare `fontdata_8x8` and `fontdata_8x16` respectively, and this file > has nothing to do with them. > > Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com> This was unused ever since this driver was merged into 2.1.67 (I looked at historical linux git trees quickly). Save to delete I'd say, probably just copypasted from some outdated driver template that was even older. Applied to drm-misc-next. -Daniel > --- > $ # Build-tested (Ubuntu 20.04) > $ sudo apt install gcc-m68k-linux-gnu > $ cp arch/m68k/configs/atari_defconfig .config > $ make ARCH=m68k menuconfig > $ make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu- -j`nproc` all > > drivers/video/fbdev/atafb.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c > index f253daa05d9d..e3812a8ff55a 100644 > --- a/drivers/video/fbdev/atafb.c > +++ b/drivers/video/fbdev/atafb.c > @@ -240,14 +240,6 @@ static int *MV300_reg = MV300_reg_8bit; > > static int inverse; > > -extern int fontheight_8x8; > -extern int fontwidth_8x8; > -extern unsigned char fontdata_8x8[]; > - > -extern int fontheight_8x16; > -extern int fontwidth_8x16; > -extern unsigned char fontdata_8x16[]; > - > /* > * struct fb_ops { > * * open/release and usage marking > -- > 2.25.1 >
On Tue, Oct 27, 2020 at 6:12 PM Peilin Ye <yepeilin.cs@gmail.com> wrote: > Remove 6 unused extern variables to reduce confusion. It is worth > mentioning that lib/fonts/font_8x8.c and lib/fonts/font_8x16.c also > declare `fontdata_8x8` and `fontdata_8x16` respectively, and this file > has nothing to do with them. > > Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert
Am 27.10.20 um 17:31 schrieb Peilin Ye: > Remove 6 unused extern variables to reduce confusion. It is worth > mentioning that lib/fonts/font_8x8.c and lib/fonts/font_8x16.c also > declare `fontdata_8x8` and `fontdata_8x16` respectively, and this file > has nothing to do with them. > > Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > $ # Build-tested (Ubuntu 20.04) > $ sudo apt install gcc-m68k-linux-gnu > $ cp arch/m68k/configs/atari_defconfig .config > $ make ARCH=m68k menuconfig > $ make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu- -j`nproc` all > > drivers/video/fbdev/atafb.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c > index f253daa05d9d..e3812a8ff55a 100644 > --- a/drivers/video/fbdev/atafb.c > +++ b/drivers/video/fbdev/atafb.c > @@ -240,14 +240,6 @@ static int *MV300_reg = MV300_reg_8bit; > > static int inverse; > > -extern int fontheight_8x8; > -extern int fontwidth_8x8; > -extern unsigned char fontdata_8x8[]; > - > -extern int fontheight_8x16; > -extern int fontwidth_8x16; > -extern unsigned char fontdata_8x16[]; > - > /* > * struct fb_ops { > * * open/release and usage marking >
diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c index f253daa05d9d..e3812a8ff55a 100644 --- a/drivers/video/fbdev/atafb.c +++ b/drivers/video/fbdev/atafb.c @@ -240,14 +240,6 @@ static int *MV300_reg = MV300_reg_8bit; static int inverse; -extern int fontheight_8x8; -extern int fontwidth_8x8; -extern unsigned char fontdata_8x8[]; - -extern int fontheight_8x16; -extern int fontwidth_8x16; -extern unsigned char fontdata_8x16[]; - /* * struct fb_ops { * * open/release and usage marking
Remove 6 unused extern variables to reduce confusion. It is worth mentioning that lib/fonts/font_8x8.c and lib/fonts/font_8x16.c also declare `fontdata_8x8` and `fontdata_8x16` respectively, and this file has nothing to do with them. Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com> --- $ # Build-tested (Ubuntu 20.04) $ sudo apt install gcc-m68k-linux-gnu $ cp arch/m68k/configs/atari_defconfig .config $ make ARCH=m68k menuconfig $ make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu- -j`nproc` all drivers/video/fbdev/atafb.c | 8 -------- 1 file changed, 8 deletions(-)