mbox series

[0/4] dmaengine: dw-axi-dmac: Refactor descriptor and channel management

Message ID 1599213094-30144-1-git-send-email-jee.heng.sia@intel.com (mailing list archive)
Headers show
Series dmaengine: dw-axi-dmac: Refactor descriptor and channel management | expand

Message

Sia Jee Heng Sept. 4, 2020, 9:51 a.m. UTC
The below patch series are to support AxiDMA running on Intel KeemBay SoC.
The base driver is dw-axi-dmac but code refactoring is needed to improve
the descriptor management by replacing Linked List Item (LLI) with
virtual descriptor management, only allocate hardware LLI memories from
DMA memory pool, manage DMA memory pool alloc/destroy based on channel
activity and to support device_sync callback.

Note: Intel KeemBay AxiDMA related changes and other DMA features are
to be submitted as we need to get the fundamental changes approved first
prior to add additional DMA features on top.

This patch series are tested on Intel KeemBay platform.

Sia Jee Heng (4):
  dt-bindings: dma: Add YAML schemas for dw-axi-dmac
  dmaengine: dw-axi-dmac: simplify descriptor management
  dmaengine: dw-axi-dmac: move dma_pool_create() to
    alloc_chan_resources()
  dmaengine: dw-axi-dmac: Add device_synchronize() callback

 .../devicetree/bindings/dma/snps,dw-axi-dmac.txt   |  39 -----
 .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml  | 124 ++++++++++++++
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c     | 190 ++++++++++++---------
 drivers/dma/dw-axi-dmac/dw-axi-dmac.h              |  11 +-
 4 files changed, 245 insertions(+), 119 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt
 create mode 100644 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml

Comments

Sia Jee Heng Sept. 18, 2020, 2:31 a.m. UTC | #1
Hi Vinod, Hi Paltsev,

This patch series has been sent 2 weeks ago, but yet to receive a comment. 
This patch series have been reviewed by Andy before sent out.

May I know if you have further comment on the patches?

Thanks
Regards
Jee Heng

> -----Original Message-----
> From: Sia, Jee Heng <jee.heng.sia@intel.com>
> Sent: 04 September 2020 5:52 PM
> To: dmaengine@vger.kernel.org
> Cc: vkoul@kernel.org; Eugeniy.Paltsev@synopsys.com; Shevchenko, Andriy
> <andriy.shevchenko@intel.com>; Sia, Jee Heng <jee.heng.sia@intel.com>
> Subject: [PATCH 0/4] dmaengine: dw-axi-dmac: Refactor descriptor and channel
> management
> 
> The below patch series are to support AxiDMA running on Intel KeemBay SoC.
> The base driver is dw-axi-dmac but code refactoring is needed to improve the
> descriptor management by replacing Linked List Item (LLI) with virtual descriptor
> management, only allocate hardware LLI memories from DMA memory pool,
> manage DMA memory pool alloc/destroy based on channel activity and to
> support device_sync callback.
> 
> Note: Intel KeemBay AxiDMA related changes and other DMA features are to be
> submitted as we need to get the fundamental changes approved first prior to
> add additional DMA features on top.
> 
> This patch series are tested on Intel KeemBay platform.
> 
> Sia Jee Heng (4):
>   dt-bindings: dma: Add YAML schemas for dw-axi-dmac
>   dmaengine: dw-axi-dmac: simplify descriptor management
>   dmaengine: dw-axi-dmac: move dma_pool_create() to
>     alloc_chan_resources()
>   dmaengine: dw-axi-dmac: Add device_synchronize() callback
> 
>  .../devicetree/bindings/dma/snps,dw-axi-dmac.txt   |  39 -----
>  .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml  | 124 ++++++++++++++
>  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c     | 190 ++++++++++++------
> ---
>  drivers/dma/dw-axi-dmac/dw-axi-dmac.h              |  11 +-
>  4 files changed, 245 insertions(+), 119 deletions(-)  delete mode 100644
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt
>  create mode 100644 Documentation/devicetree/bindings/dma/snps,dw-axi-
> dmac.yaml
> 
> --
> 1.9.1
Vinod Koul Oct. 28, 2020, 5:58 a.m. UTC | #2
On 18-09-20, 02:31, Sia, Jee Heng wrote:
> Hi Vinod, Hi Paltsev,
> 
> This patch series has been sent 2 weeks ago, but yet to receive a comment. 
> This patch series have been reviewed by Andy before sent out.

Last two weeks were merge window, now that rc1 is out, I plan to review
this in a week or so (other patches are also in queue)

Please have patience wrt reviews and keep in mind things like merge
windows etc!

> 
> May I know if you have further comment on the patches?
> 
> Thanks
> Regards
> Jee Heng
> 
> > -----Original Message-----
> > From: Sia, Jee Heng <jee.heng.sia@intel.com>
> > Sent: 04 September 2020 5:52 PM
> > To: dmaengine@vger.kernel.org
> > Cc: vkoul@kernel.org; Eugeniy.Paltsev@synopsys.com; Shevchenko, Andriy
> > <andriy.shevchenko@intel.com>; Sia, Jee Heng <jee.heng.sia@intel.com>
> > Subject: [PATCH 0/4] dmaengine: dw-axi-dmac: Refactor descriptor and channel
> > management
> > 
> > The below patch series are to support AxiDMA running on Intel KeemBay SoC.
> > The base driver is dw-axi-dmac but code refactoring is needed to improve the
> > descriptor management by replacing Linked List Item (LLI) with virtual descriptor
> > management, only allocate hardware LLI memories from DMA memory pool,
> > manage DMA memory pool alloc/destroy based on channel activity and to
> > support device_sync callback.
> > 
> > Note: Intel KeemBay AxiDMA related changes and other DMA features are to be
> > submitted as we need to get the fundamental changes approved first prior to
> > add additional DMA features on top.
> > 
> > This patch series are tested on Intel KeemBay platform.
> > 
> > Sia Jee Heng (4):
> >   dt-bindings: dma: Add YAML schemas for dw-axi-dmac
> >   dmaengine: dw-axi-dmac: simplify descriptor management
> >   dmaengine: dw-axi-dmac: move dma_pool_create() to
> >     alloc_chan_resources()
> >   dmaengine: dw-axi-dmac: Add device_synchronize() callback
> > 
> >  .../devicetree/bindings/dma/snps,dw-axi-dmac.txt   |  39 -----
> >  .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml  | 124 ++++++++++++++
> >  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c     | 190 ++++++++++++------
> > ---
> >  drivers/dma/dw-axi-dmac/dw-axi-dmac.h              |  11 +-
> >  4 files changed, 245 insertions(+), 119 deletions(-)  delete mode 100644
> > Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt
> >  create mode 100644 Documentation/devicetree/bindings/dma/snps,dw-axi-
> > dmac.yaml
> > 
> > --
> > 1.9.1