| Message ID | 155123c77b1a068089421022c4c5b1ccb75defd8.1603372719.git.andreyknvl@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kasan: hardware tag-based mode for production use on arm64 | expand |
On Thu, Oct 22, 2020 at 3:19 PM 'Andrey Konovalov' via kasan-dev <kasan-dev@googlegroups.com> wrote: > > Similarly to kasan_init() mark kasan_init_tags() as __init. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > Link: https://linux-review.googlesource.com/id/I8792e22f1ca5a703c5e979969147968a99312558 Reviewed-by: Dmitry Vyukov <dvyukov@google.com> init_tags itself is not __init, but that's added in a different patch. I've commented on that patch. > --- > include/linux/kasan.h | 2 +- > mm/kasan/hw_tags.c | 2 +- > mm/kasan/sw_tags.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 7be9fb9146ac..93d9834b7122 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -185,7 +185,7 @@ static inline void kasan_record_aux_stack(void *ptr) {} > > #if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) > > -void kasan_init_tags(void); > +void __init kasan_init_tags(void); > > void *kasan_reset_tag(const void *addr); > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index 2a38885014e3..0128062320d5 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -15,7 +15,7 @@ > > #include "kasan.h" > > -void kasan_init_tags(void) > +void __init kasan_init_tags(void) > { > init_tags(KASAN_TAG_MAX); > } > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > index c10863a45775..bf1422282bb5 100644 > --- a/mm/kasan/sw_tags.c > +++ b/mm/kasan/sw_tags.c > @@ -35,7 +35,7 @@ > > static DEFINE_PER_CPU(u32, prng_state); > > -void kasan_init_tags(void) > +void __init kasan_init_tags(void) > { > int cpu; > > -- > 2.29.0.rc1.297.gfa9743e501-goog > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/155123c77b1a068089421022c4c5b1ccb75defd8.1603372719.git.andreyknvl%40google.com.
On Wed, Oct 28, 2020 at 11:08 AM Dmitry Vyukov <dvyukov@google.com> wrote: > > On Thu, Oct 22, 2020 at 3:19 PM 'Andrey Konovalov' via kasan-dev > <kasan-dev@googlegroups.com> wrote: > > > > Similarly to kasan_init() mark kasan_init_tags() as __init. > > > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > > Link: https://linux-review.googlesource.com/id/I8792e22f1ca5a703c5e979969147968a99312558 > > Reviewed-by: Dmitry Vyukov <dvyukov@google.com> > > init_tags itself is not __init, but that's added in a different patch. > I've commented on that patch. Will add that change to this patch, thanks! If we combine the two patch series, we can move this into the other one later. Thanks! > > > --- > > include/linux/kasan.h | 2 +- > > mm/kasan/hw_tags.c | 2 +- > > mm/kasan/sw_tags.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > > index 7be9fb9146ac..93d9834b7122 100644 > > --- a/include/linux/kasan.h > > +++ b/include/linux/kasan.h > > @@ -185,7 +185,7 @@ static inline void kasan_record_aux_stack(void *ptr) {} > > > > #if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) > > > > -void kasan_init_tags(void); > > +void __init kasan_init_tags(void); > > > > void *kasan_reset_tag(const void *addr); > > > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > > index 2a38885014e3..0128062320d5 100644 > > --- a/mm/kasan/hw_tags.c > > +++ b/mm/kasan/hw_tags.c > > @@ -15,7 +15,7 @@ > > > > #include "kasan.h" > > > > -void kasan_init_tags(void) > > +void __init kasan_init_tags(void) > > { > > init_tags(KASAN_TAG_MAX); > > } > > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > > index c10863a45775..bf1422282bb5 100644 > > --- a/mm/kasan/sw_tags.c > > +++ b/mm/kasan/sw_tags.c > > @@ -35,7 +35,7 @@ > > > > static DEFINE_PER_CPU(u32, prng_state); > > > > -void kasan_init_tags(void) > > +void __init kasan_init_tags(void) > > { > > int cpu; > > > > -- > > 2.29.0.rc1.297.gfa9743e501-goog > > > > -- > > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/155123c77b1a068089421022c4c5b1ccb75defd8.1603372719.git.andreyknvl%40google.com.
diff --git a/include/linux/kasan.h b/include/linux/kasan.h index 7be9fb9146ac..93d9834b7122 100644 --- a/include/linux/kasan.h +++ b/include/linux/kasan.h @@ -185,7 +185,7 @@ static inline void kasan_record_aux_stack(void *ptr) {} #if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) -void kasan_init_tags(void); +void __init kasan_init_tags(void); void *kasan_reset_tag(const void *addr); diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c index 2a38885014e3..0128062320d5 100644 --- a/mm/kasan/hw_tags.c +++ b/mm/kasan/hw_tags.c @@ -15,7 +15,7 @@ #include "kasan.h" -void kasan_init_tags(void) +void __init kasan_init_tags(void) { init_tags(KASAN_TAG_MAX); } diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c index c10863a45775..bf1422282bb5 100644 --- a/mm/kasan/sw_tags.c +++ b/mm/kasan/sw_tags.c @@ -35,7 +35,7 @@ static DEFINE_PER_CPU(u32, prng_state); -void kasan_init_tags(void) +void __init kasan_init_tags(void) { int cpu;
Similarly to kasan_init() mark kasan_init_tags() as __init. Signed-off-by: Andrey Konovalov <andreyknvl@google.com> Link: https://linux-review.googlesource.com/id/I8792e22f1ca5a703c5e979969147968a99312558 --- include/linux/kasan.h | 2 +- mm/kasan/hw_tags.c | 2 +- mm/kasan/sw_tags.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)