[v2,0/5] scsi: target: COMPARE AND WRITE miscompare sense

Message

David Disseldorp Oct. 26, 2020, 7:06 p.m. UTC

This patchset adds missing functionality to return the offset of
non-matching read/compare data in the sense INFORMATION field on
COMPARE AND WRITE miscompare.

The functionality can be tested using the libiscsi
CompareAndWrite.MiscompareSense test proposed via:
  https://github.com/sahlberg/libiscsi/pull/344

Changes since v1:
- drop unnecessary WARN_ON()
- fix two checkpatch warnings
- drop single-use nlbas variable
- avoid compare_len recalculation

Cheers, David

 drivers/target/target_core_sbc.c       | 137 +++++++++++++++----------
 drivers/target/target_core_transport.c |  33 +++---
 include/target/target_core_base.h      |   2 +-
 lib/scatterlist.c                      |   2 +-
 4 files changed, 102 insertions(+), 72 deletions(-)

Comments

Mike Christie Oct. 27, 2020, 5:49 a.m. UTC | #1

On 10/26/20 2:06 PM, David Disseldorp wrote:
> This patchset adds missing functionality to return the offset of
> non-matching read/compare data in the sense INFORMATION field on
> COMPARE AND WRITE miscompare.
> 
> The functionality can be tested using the libiscsi
> CompareAndWrite.MiscompareSense test proposed via:
>    https://urldefense.com/v3/__https://github.com/sahlberg/libiscsi/pull/344__;!!GqivPVa7Brio!LJ-un7MDdHXhZgIK1qgvDgza2El16FK-T_4oDi6VqM0CzetAV9pGHDvLDrZUkITTHxhO$
> 
> Changes since v1:
> - drop unnecessary WARN_ON()
> - fix two checkpatch warnings
> - drop single-use nlbas variable
> - avoid compare_len recalculation
> 
> Cheers, David
> 
>   drivers/target/target_core_sbc.c       | 137 +++++++++++++++----------
>   drivers/target/target_core_transport.c |  33 +++---
>   include/target/target_core_base.h      |   2 +-
>   lib/scatterlist.c                      |   2 +-
>   4 files changed, 102 insertions(+), 72 deletions(-)


Reviewed-by: Mike Christie <[e-mail]>

David Disseldorp Oct. 27, 2020, 9:57 a.m. UTC | #2

On Tue, 27 Oct 2020 00:49:23 -0500, Mike Christie wrote:

> On 10/26/20 2:06 PM, David Disseldorp wrote:
> > This patchset adds missing functionality to return the offset of
> > non-matching read/compare data in the sense INFORMATION field on
> > COMPARE AND WRITE miscompare.
...
> > Changes since v1:
> > - drop unnecessary WARN_ON()
> > - fix two checkpatch warnings
> > - drop single-use nlbas variable
> > - avoid compare_len recalculation
> > 
> > Cheers, David
> > 
> >   drivers/target/target_core_sbc.c       | 137 +++++++++++++++----------
> >   drivers/target/target_core_transport.c |  33 +++---
> >   include/target/target_core_base.h      |   2 +-
> >   lib/scatterlist.c                      |   2 +-
> >   4 files changed, 102 insertions(+), 72 deletions(-)  
> 
> 
> Reviewed-by: Mike Christie <[e-mail]>

Thanks Mike.
@Martin: please pull patches 2/5 through to 5/5 only; the independent
scatterlist patch 1/5 has been submitted via linux-block.

Cheers, David

Martin K. Petersen Oct. 30, 2020, 2:02 a.m. UTC | #3

David,

> This patchset adds missing functionality to return the offset of
> non-matching read/compare data in the sense INFORMATION field on
> COMPARE AND WRITE miscompare.

Applied 2-5 to 5.11/scsi-staging, thanks!

Martin K. Petersen Oct. 30, 2020, 2:06 a.m. UTC | #4

>> This patchset adds missing functionality to return the offset of
>> non-matching read/compare data in the sense INFORMATION field on
>> COMPARE AND WRITE miscompare.
>
> Applied 2-5 to 5.11/scsi-staging, thanks!

Dropped again, breaks IB.

David Disseldorp Oct. 30, 2020, 2:06 p.m. UTC | #5

On Thu, 29 Oct 2020 22:06:00 -0400, Martin K. Petersen wrote:

> >> This patchset adds missing functionality to return the offset of
> >> non-matching read/compare data in the sense INFORMATION field on
> >> COMPARE AND WRITE miscompare.  
> >
> > Applied 2-5 to 5.11/scsi-staging, thanks!  
> 
> Dropped again, breaks IB.
> 

Hmm, I overlooked ib_isert in the bad_sector->sense_info rename, sorry.
I'll post a v3 when done with testing.

Cheers, David