Message ID | 20201031085810.450489-2-hch@lst.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [01/11] mtd_blkdevs: don't override BLKFLSBUF | expand |
On Sat, Oct 31, 2020 at 10:08 AM Christoph Hellwig <hch@lst.de> wrote: > > BLKFLSBUF does not actually send a flush command to the device, but > teard down buffer cache structures. Remove the mtd_blkdevs > implementation and just use the default semantics instead. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Richard Weinberger <richard@nod.at>
On 31/10/2020 08:58, Christoph Hellwig wrote: > BLKFLSBUF does not actually send a flush command to the device, but > teard down buffer cache structures. Remove the mtd_blkdevs ^^^^^ ?tears? > implementation and just use the default semantics instead. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- Cheers, Wol
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 0c05f77f9b216e..fb8e12d590a13a 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -298,38 +298,10 @@ static int blktrans_getgeo(struct block_device *bdev, struct hd_geometry *geo) return ret; } -static int blktrans_ioctl(struct block_device *bdev, fmode_t mode, - unsigned int cmd, unsigned long arg) -{ - struct mtd_blktrans_dev *dev = blktrans_dev_get(bdev->bd_disk); - int ret = -ENXIO; - - if (!dev) - return ret; - - mutex_lock(&dev->lock); - - if (!dev->mtd) - goto unlock; - - switch (cmd) { - case BLKFLSBUF: - ret = dev->tr->flush ? dev->tr->flush(dev) : 0; - break; - default: - ret = -ENOTTY; - } -unlock: - mutex_unlock(&dev->lock); - blktrans_dev_put(dev); - return ret; -} - static const struct block_device_operations mtd_block_ops = { .owner = THIS_MODULE, .open = blktrans_open, .release = blktrans_release, - .ioctl = blktrans_ioctl, .getgeo = blktrans_getgeo, };
BLKFLSBUF does not actually send a flush command to the device, but teard down buffer cache structures. Remove the mtd_blkdevs implementation and just use the default semantics instead. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/mtd/mtd_blkdevs.c | 28 ---------------------------- 1 file changed, 28 deletions(-)