| Message ID | 1604190857-3078-1-git-send-email-pgreco@centosproject.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY | expand |
Dne nedelja, 01. november 2020 ob 01:34:15 CET je Pablo Greco napisal(a): > The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on > the PHY, using pull-ups on the RXDLY and TXDLY pins. > > Fix the phy-mode description to correct reflect this so that the > implementation doesn't reconfigure the delays incorrectly. This > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > rx/tx delay config"). > > Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board") > Signed-off-by: Pablo Greco <pgreco@centosproject.org> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Thanks! Jernej
Hi, On Sat, Oct 31, 2020 at 09:34:15PM -0300, Pablo Greco wrote: > The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on > the PHY, using pull-ups on the RXDLY and TXDLY pins. > > Fix the phy-mode description to correct reflect this so that the > implementation doesn't reconfigure the delays incorrectly. This > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > rx/tx delay config"). > > Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board") > Signed-off-by: Pablo Greco <pgreco@centosproject.org> Thanks for sending those patches. However, I'm not entirely sure how you sent it but the odd threading you used (each other patches being in reply to this one without 0/N in the name) seem to confuse the tools we use to apply the patches. Can you resend it properly? Thanks! Maxime
On 2/11/20 11:07, Maxime Ripard wrote: > Hi, > > On Sat, Oct 31, 2020 at 09:34:15PM -0300, Pablo Greco wrote: >> The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on >> the PHY, using pull-ups on the RXDLY and TXDLY pins. >> >> Fix the phy-mode description to correct reflect this so that the >> implementation doesn't reconfigure the delays incorrectly. This >> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e >> rx/tx delay config"). >> >> Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board") >> Signed-off-by: Pablo Greco <pgreco@centosproject.org> > Thanks for sending those patches. > > However, I'm not entirely sure how you sent it but the odd threading you > used (each other patches being in reply to this one without 0/N in the > name) seem to confuse the tools we use to apply the patches. > > Can you resend it properly? > Thanks! > Maxime I prepared them individually but sent them together in a single git-send-email, that must have been the problem. I"ll send them again one by one. Pablo.
diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts index bb3987e101c2..0b3d9ae75650 100644 --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts @@ -132,7 +132,7 @@ pinctrl-names = "default"; pinctrl-0 = <&gmac_rgmii_pins>; phy-handle = <&phy1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-supply = <®_gmac_3v3>; status = "okay"; };
The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. Fix the phy-mode description to correct reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board") Signed-off-by: Pablo Greco <pgreco@centosproject.org> --- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)