mbox series

[0/2] ASoC: stm32: i2s: add master clock provider

Message ID 20200911091952.14696-1-olivier.moysan@st.com (mailing list archive)
Headers show
Series ASoC: stm32: i2s: add master clock provider | expand

Message

Olivier MOYSAN Sept. 11, 2020, 9:19 a.m. UTC
Add master clock generation support in STM32 I2S driver.

Olivier Moysan (2):
  ASoC: dt-bindings: add mclk provider support to stm32 i2s
  ASoC: stm32: i2s: add master clock provider

 .../bindings/sound/st,stm32-i2s.yaml          |   4 +
 sound/soc/stm/stm32_i2s.c                     | 310 +++++++++++++++---
 2 files changed, 270 insertions(+), 44 deletions(-)

Comments

Olivier MOYSAN Nov. 3, 2020, 1:38 p.m. UTC | #1
Hi Mark,

Gentle reminder on this series, as it seems that there was no update 
since Rob's "reviewed-by" for dt bindings, on 11/09.

BRs
Olivier

On 9/11/20 11:19 AM, Olivier Moysan wrote:
> Add master clock generation support in STM32 I2S driver.
> 
> Olivier Moysan (2):
>    ASoC: dt-bindings: add mclk provider support to stm32 i2s
>    ASoC: stm32: i2s: add master clock provider
> 
>   .../bindings/sound/st,stm32-i2s.yaml          |   4 +
>   sound/soc/stm/stm32_i2s.c                     | 310 +++++++++++++++---
>   2 files changed, 270 insertions(+), 44 deletions(-)
>
Mark Brown Nov. 3, 2020, 2:53 p.m. UTC | #2
On Tue, Nov 03, 2020 at 01:38:27PM +0000, Olivier MOYSAN wrote:
> Hi Mark,
> 
> Gentle reminder on this series, as it seems that there was no update 
> since Rob's "reviewed-by" for dt bindings, on 11/09.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.