| Message ID | 20201106190337.1973127-24-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/24] block: remove the call to __invalidate_device in check_disk_size_change | expand |
On 06/11/20 20:03, Christoph Hellwig wrote: > revalidate_disk_size just updates the block device size from the disk > size. Thus calling it from revalidate_disk_size doesn't actually do s/revalidate_disk_size/virtblk_update_cache_mode/ > anything.
On Fri, Nov 06, 2020 at 08:03:35PM +0100, Christoph Hellwig wrote: > revalidate_disk_size just updates the block device size from the disk > size. Thus calling it from revalidate_disk_size doesn't actually do > anything. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/block/virtio_blk.c | 1 - > 1 file changed, 1 deletion(-) Modulo Paolo's comment: Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
On Fri, Nov 06, 2020 at 08:03:35PM +0100, Christoph Hellwig wrote: > revalidate_disk_size just updates the block device size from the disk > size. Thus calling it from revalidate_disk_size doesn't actually do > anything. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Michael S. Tsirkin <mst@redhat.com> > --- > drivers/block/virtio_blk.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 3e812b4c32e669..145606dc52db1e 100644 > --- a/drivers/block/virtio_blk.c > +++ b/drivers/block/virtio_blk.c > @@ -598,7 +598,6 @@ static void virtblk_update_cache_mode(struct virtio_device *vdev) > struct virtio_blk *vblk = vdev->priv; > > blk_queue_write_cache(vblk->disk->queue, writeback, false); > - revalidate_disk_size(vblk->disk, true); > } > > static const char *const virtblk_cache_types[] = { > -- > 2.28.0
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 3e812b4c32e669..145606dc52db1e 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -598,7 +598,6 @@ static void virtblk_update_cache_mode(struct virtio_device *vdev) struct virtio_blk *vblk = vdev->priv; blk_queue_write_cache(vblk->disk->queue, writeback, false); - revalidate_disk_size(vblk->disk, true); } static const char *const virtblk_cache_types[] = {
revalidate_disk_size just updates the block device size from the disk size. Thus calling it from revalidate_disk_size doesn't actually do anything. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/virtio_blk.c | 1 - 1 file changed, 1 deletion(-)