| Message ID | 1604346639-27090-1-git-send-email-alejandro.j.jimenez@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] pvpanic: Advertise the PVPANIC_CRASHLOADED event support | expand |
Hi, Paolo This patch seems getting ignored. Because no maintainers found for hw/misc/pvpanic.c, I also send this to you(hope it doesn't disturb you). About this patch: Looks good. And also test it, works fine. Reviewed-by: zhenwei pi <pizhenwei@bytedance.com> On 11/3/20 3:50 AM, Alejandro Jimenez wrote: > Advertise both types of events supported when the guest OS > queries the pvpanic device. Currently only PVPANIC_PANICKED is > exposed; PVPANIC_CRASHLOADED must also be advertised. > > Fixes: 7dc58deea79a ("pvpanic: implement crashloaded event handling") > Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com> > Acked-by: Mark Kanda <mark.kanda@oracle.com> > --- > hw/misc/pvpanic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > index 598d547..a55ce8e 100644 > --- a/hw/misc/pvpanic.c > +++ b/hw/misc/pvpanic.c > @@ -66,7 +66,7 @@ struct PVPanicState { > /* return supported events on read */ > static uint64_t pvpanic_ioport_read(void *opaque, hwaddr addr, unsigned size) > { > - return PVPANIC_PANICKED; > + return PVPANIC_PANICKED | PVPANIC_CRASHLOADED; > } > > static void pvpanic_ioport_write(void *opaque, hwaddr addr, uint64_t val, >
On 09/11/20 12:40, zhenwei pi wrote: > Hi, Paolo > > This patch seems getting ignored. Because no maintainers found for > hw/misc/pvpanic.c, I also send this to you(hope it doesn't disturb you). > > > About this patch: > Looks good. And also test it, works fine. > > Reviewed-by: zhenwei pi <pizhenwei@bytedance.com> > > On 11/3/20 3:50 AM, Alejandro Jimenez wrote: >> Advertise both types of events supported when the guest OS >> queries the pvpanic device. Currently only PVPANIC_PANICKED is >> exposed; PVPANIC_CRASHLOADED must also be advertised. >> >> Fixes: 7dc58deea79a ("pvpanic: implement crashloaded event handling") >> Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com> >> Acked-by: Mark Kanda <mark.kanda@oracle.com> >> --- >> hw/misc/pvpanic.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c >> index 598d547..a55ce8e 100644 >> --- a/hw/misc/pvpanic.c >> +++ b/hw/misc/pvpanic.c >> @@ -66,7 +66,7 @@ struct PVPanicState { >> /* return supported events on read */ >> static uint64_t pvpanic_ioport_read(void *opaque, hwaddr addr, >> unsigned size) >> { >> - return PVPANIC_PANICKED; >> + return PVPANIC_PANICKED | PVPANIC_CRASHLOADED; >> } >> static void pvpanic_ioport_write(void *opaque, hwaddr addr, uint64_t >> val, >> > Queued now, thanks Zhenwei. Paolo
On 09/11/20 12:40, zhenwei pi wrote: > Hi, Paolo > > This patch seems getting ignored. Because no maintainers found for > hw/misc/pvpanic.c, I also send this to you(hope it doesn't disturb you). Actually it needs compat stuff for old machine types. I'll send v2.
diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index 598d547..a55ce8e 100644 --- a/hw/misc/pvpanic.c +++ b/hw/misc/pvpanic.c @@ -66,7 +66,7 @@ struct PVPanicState { /* return supported events on read */ static uint64_t pvpanic_ioport_read(void *opaque, hwaddr addr, unsigned size) { - return PVPANIC_PANICKED; + return PVPANIC_PANICKED | PVPANIC_CRASHLOADED; } static void pvpanic_ioport_write(void *opaque, hwaddr addr, uint64_t val,
Advertise both types of events supported when the guest OS queries the pvpanic device. Currently only PVPANIC_PANICKED is exposed; PVPANIC_CRASHLOADED must also be advertised. Fixes: 7dc58deea79a ("pvpanic: implement crashloaded event handling") Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com> Acked-by: Mark Kanda <mark.kanda@oracle.com> --- hw/misc/pvpanic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)