| Message ID | 20201106061433.1483129-2-ajye_huang@compal.corp-partner.google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0e38d93493c7b11bc250113dd5b7b9d17ba8c54d |
| Headers | show |
| Series | Modify documentation and machine driver for SC7180 sound card | expand |
Hi, Rob I follow your suggests that adding (maxItems: 1) for dmic-gpis property, and keep one example of adding dmic-gpios property in it Could you please kindly review it ? Thank you so much Ajye On Fri, Nov 6, 2020 at 2:14 PM Ajye Huang <ajye.huang@gmail.com> wrote: > > Add a property "dmic-gpios" for switching between two MICs. > > Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com> > --- > .../devicetree/bindings/sound/google,sc7180-trogdor.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > index efc34689d6b5..ce050a9dec94 100644 > --- a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > +++ b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > @@ -34,6 +34,10 @@ properties: > "#size-cells": > const: 0 > > + dmic-gpios: > + maxItems: 1 > + description: GPIO for switching between DMICs > + > patternProperties: > "^dai-link(@[0-9])?$": > description: > @@ -83,7 +87,7 @@ examples: > - | > sound { > compatible = "google,sc7180-trogdor"; > - model = "sc7180-rt5682-max98357a-1mic"; > + model = "sc7180-rt5682-max98357a-2mic"; > > audio-routing = > "Headphone Jack", "HPOL", > @@ -92,6 +96,8 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > + dmic-gpios = <&tlmm 86 0>; > + > dai-link@0 { > link-name = "MultiMedia0"; > reg = <0>; > -- > 2.25.1 >
On Fri, 06 Nov 2020 14:14:32 +0800, Ajye Huang wrote: > Add a property "dmic-gpios" for switching between two MICs. > > Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com> > --- > .../devicetree/bindings/sound/google,sc7180-trogdor.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml index efc34689d6b5..ce050a9dec94 100644 --- a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml +++ b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml @@ -34,6 +34,10 @@ properties: "#size-cells": const: 0 + dmic-gpios: + maxItems: 1 + description: GPIO for switching between DMICs + patternProperties: "^dai-link(@[0-9])?$": description: @@ -83,7 +87,7 @@ examples: - | sound { compatible = "google,sc7180-trogdor"; - model = "sc7180-rt5682-max98357a-1mic"; + model = "sc7180-rt5682-max98357a-2mic"; audio-routing = "Headphone Jack", "HPOL", @@ -92,6 +96,8 @@ examples: #address-cells = <1>; #size-cells = <0>; + dmic-gpios = <&tlmm 86 0>; + dai-link@0 { link-name = "MultiMedia0"; reg = <0>;
Add a property "dmic-gpios" for switching between two MICs. Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com> --- .../devicetree/bindings/sound/google,sc7180-trogdor.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)