| Message ID | 20201110135201.GA90549@nstpc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | libceph: remove unused defined macro for port | expand |
On Tue, 2020-11-10 at 21:52 +0800, changcheng.liu@intel.com wrote: > 1. monitor's default port is defined by CEPH_MON_PORT > 2. CEPH_PORT_START & CEPH_PORT_LAST are not needed. > > Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com> > > diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h > index 1c1887206ffa..feff5a2dc33e 100644 > --- a/include/linux/ceph/msgr.h > +++ b/include/linux/ceph/msgr.h > @@ -7,15 +7,6 @@ > > > #define CEPH_MON_PORT 6789 /* default monitor port */ > > > -/* > - * client-side processes will try to bind to ports in this > - * range, simply for the benefit of tools like nmap or wireshark > - * that would like to identify the protocol. > - */ > -#define CEPH_PORT_FIRST 6789 > -#define CEPH_PORT_START 6800 /* non-monitors start here */ > -#define CEPH_PORT_LAST 6900 > - > /* > * tcp connection banner. include a protocol version. and adjust > * whenever the wire protocol changes. try to keep this string length Thanks! Merged into testing branch. Cheers,
On Tue, Nov 10, 2020 at 3:00 PM Jeff Layton <jlayton@kernel.org> wrote: > > On Tue, 2020-11-10 at 21:52 +0800, changcheng.liu@intel.com wrote: > > 1. monitor's default port is defined by CEPH_MON_PORT > > 2. CEPH_PORT_START & CEPH_PORT_LAST are not needed. > > > > Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com> > > > > diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h > > index 1c1887206ffa..feff5a2dc33e 100644 > > --- a/include/linux/ceph/msgr.h > > +++ b/include/linux/ceph/msgr.h > > @@ -7,15 +7,6 @@ > > > > > > #define CEPH_MON_PORT 6789 /* default monitor port */ > > > > > > -/* > > - * client-side processes will try to bind to ports in this > > - * range, simply for the benefit of tools like nmap or wireshark > > - * that would like to identify the protocol. > > - */ > > -#define CEPH_PORT_FIRST 6789 > > -#define CEPH_PORT_START 6800 /* non-monitors start here */ > > -#define CEPH_PORT_LAST 6900 > > - > > /* > > * tcp connection banner. include a protocol version. and adjust > > * whenever the wire protocol changes. try to keep this string length > > Thanks! Merged into testing branch. Jeff, the From address doesn't match the SOB address here. A few weeks ago I asked Changcheng to resend because of this and it looks like he sent two copies of the same patch today. The other one seems to be in order -- please drop this one. Thanks, Ilya
On Tue, 2020-11-10 at 17:10 +0100, Ilya Dryomov wrote: > On Tue, Nov 10, 2020 at 3:00 PM Jeff Layton <jlayton@kernel.org> wrote: > > > > On Tue, 2020-11-10 at 21:52 +0800, changcheng.liu@intel.com wrote: > > > 1. monitor's default port is defined by CEPH_MON_PORT > > > 2. CEPH_PORT_START & CEPH_PORT_LAST are not needed. > > > > > > Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com> > > > > > > diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h > > > index 1c1887206ffa..feff5a2dc33e 100644 > > > --- a/include/linux/ceph/msgr.h > > > +++ b/include/linux/ceph/msgr.h > > > @@ -7,15 +7,6 @@ > > > > > > > > > #define CEPH_MON_PORT 6789 /* default monitor port */ > > > > > > > > > -/* > > > - * client-side processes will try to bind to ports in this > > > - * range, simply for the benefit of tools like nmap or wireshark > > > - * that would like to identify the protocol. > > > - */ > > > -#define CEPH_PORT_FIRST 6789 > > > -#define CEPH_PORT_START 6800 /* non-monitors start here */ > > > -#define CEPH_PORT_LAST 6900 > > > - > > > /* > > > * tcp connection banner. include a protocol version. and adjust > > > * whenever the wire protocol changes. try to keep this string length > > > > Thanks! Merged into testing branch. > > Jeff, the From address doesn't match the SOB address here. A few > weeks ago I asked Changcheng to resend because of this and it looks > like he sent two copies of the same patch today. The other one seems > to be in order -- please drop this one. > Ok, dropped.
diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h index 1c1887206ffa..feff5a2dc33e 100644 --- a/include/linux/ceph/msgr.h +++ b/include/linux/ceph/msgr.h @@ -7,15 +7,6 @@ #define CEPH_MON_PORT 6789 /* default monitor port */ -/* - * client-side processes will try to bind to ports in this - * range, simply for the benefit of tools like nmap or wireshark - * that would like to identify the protocol. - */ -#define CEPH_PORT_FIRST 6789 -#define CEPH_PORT_START 6800 /* non-monitors start here */ -#define CEPH_PORT_LAST 6900 - /* * tcp connection banner. include a protocol version. and adjust * whenever the wire protocol changes. try to keep this string length
1. monitor's default port is defined by CEPH_MON_PORT 2. CEPH_PORT_START & CEPH_PORT_LAST are not needed. Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>