| Message ID | 20201110123915.3356601-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] Bluetooth: btrtl: fix incorrect skb allocation failure check | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=381173 ---Test result--- ############################## Test: CheckPatch - PASS ############################## Test: CheckGitLint - PASS ############################## Test: CheckBuildK - PASS --- Regards, Linux Bluetooth
Hi Colin, > Currently the check for a failed bt_skb_alloc allocation is incorrectly > checking using IS_ERR and this can lead to a null pointer dereference. Fix > this by checking for a null pointer return using the !skb idiom. > > Addresses-Coverity: ("Dereference null return") > Fixes: 1996d9cad6ad ("Bluetooth: btrtl: Ask 8821C to drop old firmware") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/bluetooth/btrtl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c index 0ac0f8874ef7..12099c40f8d6 100644 --- a/drivers/bluetooth/btrtl.c +++ b/drivers/bluetooth/btrtl.c @@ -572,7 +572,7 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev, cmd[1] = opcode >> 8; skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL); - if (IS_ERR(skb)) + if (!skb) goto out_free; skb_put_data(skb, cmd, sizeof(cmd));